8000 [3.11] gh-115165: Fix `typing.Annotated` for immutable types (GH-115213) by miss-islington · Pull Request #115228 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.11] gh-115165: Fix typing.Annotated for immutable types (GH-115213) #115228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2024
Merged

[3.11] gh-115165: Fix typing.Annotated for immutable types (GH-115213) #115228

merged 2 commits into from
Feb 9, 2024

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Feb 9, 2024 •
edited by bedevere-app bot
Loading

The return value from an annotated callable can raise any exception from
setattr for the __orig_class__ property.
(cherry picked from commit 5643856)

Co-authored-by: dave-shawley daveshawley@gmail.com

@dave-shawley @miss-islington
pythongh-115165: Fix typing.Annotated for immutable types (pythonGH…
04d81e8 
…-115213)

The return value from an annotated callable can raise any exception from
__setattr__ for the `__orig_class__` property.
(cherry picked from commit 5643856)

Co-authored-by: dave-shawley <daveshawley@gmail.com>
This was referenced Feb 9, 2024
Merged
Closed
@AlexWaygood AlexWaygood enabled auto-merge (squash) February 9, 2024 22:13
@AlexWaygood AlexWaygood self-assigned this Feb 9, 2024
Eclips4
Eclips4 reviewed Feb 9, 2024
View reviewed changes
@AlexWaygood @Eclips4
no pep-695 for you on Python 3.11
2c18de1 
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@AlexWaygood AlexWaygood merged commit 7542210 into python:3.11 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees

@AlexWaygood AlexWaygood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @AlexWaygood @Eclips4 @dave-shawley
0