Use Unicode unconditionally for _winapi.CreateFile #114611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes _winapi.CreateFile unconditionally use Unicode.
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @zooba, I could not cleanly backport this to |
|
Sorry, @zooba, I could not cleanly backport this to |
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Jan 26, 2024
Currently it switches based on build settings, but argument clinic does not handle it correctly.
|
GH-114614 is a backport of this pull request to the 3.12 branch. |
|
GH-114615 is a backport of this pull request to the 3.11 branch. |
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Jan 26, 2024
Currently it switches based on build settings, but argument clinic does not handle it correctly.
zooba
added a commit
that referenced
this pull request
Jan 26, 2024
Currently it switches based on build settings, but argument clinic does not handle it correctly.
zooba
added a commit
that referenced
this pull request
Jan 26, 2024
Currently it switches based on build settings, but argument clinic does not handle it correctly.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Currently it switches based on build settings, but argument clinic does not handle it correctly.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Currently it switches based on build settings, but argument clinic does not handle it correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.