8000 Add missing sections to blurbs by hugovk · Pull Request #114553 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Add missing sections to blurbs #114553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

Add missing sections to blurbs #114553

merged 1 commit into from
Feb 12, 2024

Conversation

hugovk
Copy link
Member
@hugovk hugovk commented Jan 25, 2024

Fixes python/core-workflow#525.

After adding more validation to blurb in python/core-workflow#507 (unreleased), blurb merge fails for these three files because they're missing a section entry.

Other "no new changes" blurbs do contain a section: Library entry:

We could modify blurb to allow files in Misc/NEWS.d/next to skip this validation, but it's easier to add the missing sections.

@hugovk hugovk added the docs Documentation in the Doc dir label Jan 25, 2024
@hugovk hugovk mentioned this pull request Jan 25, 2024
Closed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 26, 2024
@hugovk
Copy link
Member Author
hugovk commented Jan 26, 2024

We should also backport this back to 3.8, so blurb merge works for security releases too.

RMs @pablogsal @ambv, is that okay?

(This would only be a problem when the next version of blurb is released, and it's not imminently planned.)

@serhiy-storchaka
Copy link
Member

Let just create backport and left the on @pablogsal and @ambv. I think they missed your question, but it will be more difficult to miss PRs.

@hugovk hugovk merged commit dc8893a into python:main Feb 12, 2024
@hugovk hugovk deleted the misc-news-add-sections branch February 12, 2024 14:16
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2024
@hugovk @miss-islington
Add missing sections to blurbs (pythonGH-114553)
580ceeb 
(cherry picked from commit dc8893a)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2024

GH-115336 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 12, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2024
@hugovk @miss-islington
Add missing sections to blurbs (pythonGH-114553)
8fc1ae7 
(cherry picked from commit dc8893a)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2024

GH-115337 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 12, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2024
@hugovk @miss-islington
Add missing sections to blurbs (pythonGH-114553)
0054b21 
(cherry picked from commit dc8893a)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2024

GH-115338 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2024
@hugovk @miss-islington
Add missing sections to blurbs (pythonGH-114553)
cf230d5 
(cherry picked from commit dc8893a)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.10 only security fixes label Feb 12, 2024
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2024

GH-115339 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2024
@hugovk @miss-islington
Add missing sections to blurbs (pythonGH-114553)
a2f47a8 
(cherry picked from commit dc8893a)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.9 only security fixes label Feb 12, 2024
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2024

GH-115340 is a backport of this pull request to the 3.8 branch.

hugovk added a commit that referenced this pull request Feb 12, 2024
@miss-islington @hugovk
[3.11] Add missing sections to blurbs (GH-114553) (#115337)
9b6aba2 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Feb 12, 2024
@miss-islington @hugovk
[3.12] Add missing sections to blurbs (GH-114553) (#115336)
6ca300f 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@pablogsal
Copy link
Member

We should also backport this back to 3.8, so blurb merge works for security releases too.

I am fine doing this for 3.10 and 3.11. @ambv what do you think?

ambv pushed a commit that referenced this pull request Feb 13, 2024
@miss-islington @hugovk
[3.8] Add missing sections to blurbs (GH-114553) (GH-115340)
da0691d 
Add missing sections to blurbs (GH-114553)
(cherry picked from commit dc8893a)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Feb 13, 2024
@miss-islington @hugovk
[3.9] Add missing sections to blurbs (GH-114553) (GH-115339)
fa1f564 
(cherry picked from commit dc8893a)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Feb 14, 2024
@miss-islington
[3.10] Add missing sections to blurbs (GH-114553) (#115338)
0e7ff84
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@hugovk @fsc-eriker
Add missing sections to blurbs (python#114553)
deb81b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@terryjreedy terryjreedy terryjreedy approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blurb merge: "No 'section' specified. You must provide one!"
5 participants
@hugovk @serhiy-storchaka @pablogsal @terryjreedy @ezio-melotti
0