gh-114265: remove i_loc_propagated, jump threading does not consider line numbers anymore #114535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sider line numbers anymore
iritkatriel
commented
Jan 24, 2024
| expected_insts = [ | ||
| ('LOAD_NAME', 0, 10), | ||
| ('NOP', 0, 4), | ||
| (op2, 0, 5), | ||
| (op, 0, 5), |
There was a problem hiding this comment.
The expected output was wrong here (and there was a bug) - in the case of 'JUMP' --> 'JUMP_NO_INTERRUPT' we were previously ending up with 'JUMP_NO_INTERRUPT', but we want it to be 'JUMP'.
|
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…sider line numbers anymore (python#114535)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…sider line numbers anymore (python#114535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies jump threading: instead of trying to figure out whether the new and old jumps have the same line numbers, it replaces the first jump by a NOP and adds another instruction after it for the threaded jump (with the target's line number). The NOP will be removed later if it's not necessary.
After this we don't need i_loc_propagated anymore.