8000 gh-112075: Add critical sections for most dict APIs by DinoV · Pull Request #114508 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-112075: Add critical sections for most dict APIs #114508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 6, 2024
Merged

gh-112075: Add critical sections for most dict APIs #114508

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
455461b
Add macro to assert critical section is held
DinoV Jan 10, 2024
a0d1e27
Critical sections
DinoV Jan 18, 2024
584f4cb
Most dict operations should use locks
DinoV Jan 19, 2024
aa80085
Lock someplaces outside of dicts & review feedback
DinoV Jan 23, 2024
ab5d224
Fix formatting
DinoV Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Critical sections
  • Loading branch information
@DinoV
DinoV committed Feb 6, 2024
commit a0d1e275d0084a7f82c48f512916737a5a4e43f9
3 changes: 3 additions & 0 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3293,6 +3293,7 @@ dict_richcompare(PyObject *v, PyObject *w, int op)
/*[clinic input]

@coexist
@critical_section
dict.__contains__

key: object
Expand Down Expand Up @@ -3324,6 +3325,7 @@ dict___contains__(PyDictObject *self, PyObject *key)
}

/*[clinic input]
@critical_section
dict.get

key: object
Expand Down Expand Up @@ -3559,6 +3561,7 @@ dict_pop_impl(PyDictObject *self, PyObject *key, PyObject *default_value)
}

/*[clinic input]
@critical_section
dict.popitem

Remove and return a (key, value) pair as a 2-tuple.
Expand Down
0