gh-91602: Add iterdump() support for filtering database objects. #114501
Conversation
|
I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a full |
Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔. |
Yeah, that's strange; I'd rebase onto |
|
BTW, can you please use |
|
Thanks for all your help, much appreciated. I will work on tests and docs later today. |
|
Now it's ready for review 🎉 |
|
Very nice; 321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :) |
🍿 |
There was a problem hiding this comment.
The refcout refactoring in 8cf51d4 is superb; I was just about to suggest it 🚀. I left a small comment regarding how we do the vector call.
When doing changes that affect reference counting, I normally do a refleak test locally:
$ ./python.exe -m test -R : test_sqlite3
|
@erlend-aasland Thanks for all your help 🎁 |
Misc/NEWS.d/next/Library/2024-01-24-20-51-49.gh-issue-91602.8fOH8l.rst
Outdated
Show resolved
Hide resolved
|
!buildbot .refleak. |
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit e314153 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
The |
|
Thanks a lot, @felixxm! |
…python#114501) Add optional 'filter' parameter to iterdump() that allows a "LIKE" pattern for filtering database objects to dump. Co-authored-by: Erlend E. Aasland <erlend@python.org>
Uh oh!
There was an error while loading. Please reload this page.