-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-12707: deprecate info(), geturl(), getcode() methods in favor of headers, url, and status properties for HTTPResponse and addinfourl #11447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
18a7eac
bpo-12707: deprecate info(), geturl(), getcode() from HTTPResponse an…
epicfaace 2e93da4
bpo-12707: rename 'code' attribute to 'status'
epicfaace 2db7e1f
bpo-12707: Document properties and deprecation of methods
epicfaace beadb34
bpo-21257: remove deprecation warnings
epicfaace 2a16f9b
bpo-21257: fix whitespace
epicfaace f07f456
bpo-12707: remove deprecation warnings from doc
epicfaace 5640148
bpo-12707: remove deprecation warning for addurlinfo.getstatus() in docs
epicfaace 51cd8ad
bpo-12707: rename code to status in test
epicfaace c199098
bpo-12707: rename info to headers in tests
epicfaace 58ced25
Apply suggestions from code review
eamanu 13d373f
bpo-12707: Add links to doc
epicfaace 357c8b4
bpo-12707 merge changes
epicfaace b99fb9f
bpo-12707: remove empty line
epicfaace 1cf719c
bpo-12707: fix typos
epicfaace 2c3a63f
bpo-12707: add versionadded directive
epicfaace c57eb8c
bpo-12707: recommendation to use addinfourl.status instead of .code
epicfaace 2174ea5
Update Doc/library/urllib.request.rst
merwok 47f1656
bpo-12707: use email.message.EmailMessage
epicfaace 10d4720
bpo-12707: clean up wording for headers
epicfaace 1a36dfc
Merge branch 'bpo-12707' of https://github.com/epicfaace/cpython into…
epicfaace c0e78bc
bpo-12707: re-add deprecation wording in doc
epicfaace febc206
bpo-12707: Separate tests for new and old attributes
epicfaace 73a5a9a
Update Lib/urllib/request.py
merwok 1f8b27b
bpo-12707: fix indentation and formatting
epicfaace ac31a4a
Merge branch 'bpo-12707' of https://github.com/epicfaace/cpython into…
epicfaace c9e8110
bpo-12707: fix indentation
epicfaace 61385d8
bpo-12707: remove reST from docstring
epicfaace 2ee88dd
📜🤖 Added by blurb_it.
blurb-it[bot] d7575f0
Make NEWS more clear
epicfaace 628c2f0
add Deprecated warnings and update versionadded
epicfaace 5f5b2f9
Fix the call of the 'deprecated' directive
matrixise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation here is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it, thanks!