8000 gh-112050: Convert most methods on collections.deque to use Argument Clinic by mpage · Pull Request #113963 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-112050: Convert most methods on collections.deque to use Argument Clinic #113963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 29, 2024
Merged

gh-112050: Convert most methods on collections.deque to use Argument Clinic #113963

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2f9c90a
Convert most collections.deque methods to use clinic
mpage Dec 22, 2023
60b6346
Merge remote-tracking branch 'upstream/main' into ft-deque-clinic
mpage Jan 11, 2024
eefd994
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 11, 2024
991f686
Fix error in docstring for popleft
mpage Jan 11, 2024
37c4c05
Make docstring for __init__ more closely resemble the original
mpage Jan 11, 2024
35c16c2
Add missing periods in deque docstrings
mpage Jan 17, 2024
875433b
Use consistent names for value params
mpage Jan 17, 2024
3600a40
Drop the `_collections_`, it's cleaner
mpage Jan 17, 2024
b7bc0b2
Reuse existing argument names
mpage Jan 18, 2024
a306210
Merge branch 'main' into ft-deque-clinic
erlend-aasland Jan 29, 2024
934fd2e
Update Misc/NEWS.d/next/Core and Builtins/2024-01-11-22-58-45.gh-issu…
erlend-aasland Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix error in docstring for popleft 
We pop the leftmost, not the rightmost.
  • Loading branch information
@mpage
mpage committed Jan 11, 2024
commit 991f686c111bb1e339410384984b1dc862e0779b
4 changes: 2 additions & 2 deletions Modules/_collectionsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,12 @@ _collections.deque.popleft

deque: dequeobject

Remove and return the rightmost element.
Remove and return the leftmost element.
[clinic start generated code]*/

static PyObject *
_collections_deque_popleft_impl(dequeobject *deque)
/*[clinic end generated code: output=8cd77178b5116aba input=39d64df4664392d3]*/
/*[clinic end generated code: output=8cd77178b5116aba input=0ca92ec89734848a]*/
{
PyObject *item;
block *prevblock;
Expand Down
4 changes: 2 additions & 2 deletions Modules/clinic/_collectionsmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0