8000 bpo-33987: IDLE - use ttk Frame for ttk widgets by terryjreedy · Pull Request #11395 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-33987: IDLE - use ttk Frame for ttk widgets #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 3, 2019
Merged

bpo-33987: IDLE - use ttk Frame for ttk widgets #11395

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4700607
bpo-33987: IDLE - use ttk Frame for SearchDialogBase
terryjreedy Dec 31, 2018
30ce20d
Change other modules.
terryjreedy Dec 31, 2018
78a428e
Update 2018-12-31-17-04-18.bpo-33987.fD92up.rst
terryjreedy Dec 31, 2018
a03ef07
tree.py - remove temporary '#' used to test with tk widgets
terryjreedy Dec 31, 2018
a8dd9e3
Update grep.py
terryjreedy Dec 31, 2018
654856d
Use workaround for test_make_frame.
terryjreedy Jan 2, 2019
e523da9
test_searchbase whitespace
terryjreedy Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use workaround for test_make_frame. 
See terryjreedy comment in issue 33987 pr 11395.
  • Loading branch information
@terryjreedy
terryjreedy authored Jan 2, 2019
commit 654856daeea1415b0eb0f2f1ba85a00b1591c8a4
7 changes: 4 additions & 3 deletions Lib/idlelib/idle_test/test_searchbase.py
View file
Open in desktop
Or 6EA7 iginal file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,12 @@ def test_make_frame(self):
self.dialog.top = self.root
frame, label = self.dialog.make_frame()
self.assertEqual(label, '')
self.assertIsInstance(frame, Frame)

self.assertEqual(str(type(frame)), "<class 'tkinter.ttk.Frame'>")
# self.assertIsInstance(frame, Frame) fails when test is run by
# test_idle not run from IDLE editor. See issue 33987 PR.

frame, label = self.dialog.make_frame('testlabel')
self.assertEqual(label['text'], 'testlabel')
self.assertIsInstance(frame, Frame)

def btn_test_setup(self, meth):
self.dialog.top = self.root
Expand Down
0