Make deque.contains thread-safe

python · erlend-aasland · Feb 15, 2024 · Dec 22, 2023 · Dec 22, 2023 · Dec 22, 2023
commit 70f07a712a6664d27c3a9effe95be8549702fdad
@@ -1167,7 +1167,7 @@ _collections_deque_count_impl(dequeobject *deque, PyObject *v)
 }
 
 static int
-deque_contains(dequeobject *deque, PyObject *v)
+deque_contains_locked(dequeobject *deque, PyObject *v)
 {
     block *b = deque->leftblock;
     Py_ssize_t index = deque->leftindex;
@@ -1198,6 +1198,15 @@ deque_contains(dequeobject *deque, PyObject *v)
     return 0;
 }
 
+static int
+deque_contains(dequeobject *deque, PyObject *v)
+{
+    Py_BEGIN_CRITICAL_SECTION(deque);
+    int result = deque_contains_locked(deque, v);
+    Py_END_CRITICAL_SECTION();
+    return result;
+}
+
 static Py_ssize_t
 deque_len(dequeobject *deque)
 {