8000 gh-113560: Improve docs for `set.issubset` and `set.issuperset` by CharlieZhao95 · Pull Request #113562 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-113560: Improve docs for set.issubset and set.issuperset #113562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2024
Merged

gh-113560: Improve docs for set.issubset and set.issuperset #113562

merged 3 commits into from
Jan 27, 2024

Conversation

CharlieZhao95
Copy link
Contributor
@CharlieZhao95 CharlieZhao95 commented Dec 29, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 29, 2023
Closed
sobolevn
sobolevn reviewed Dec 29, 2023
View reviewed changes
Objects/setobject.c Outdated
"issubset($self, /, other)\n\
--\n\
\n\
Return True if all elements in this set are found in other(iterable).");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use other() as a callable?

Suggested change
Return True if all elements in this set are found in other(iterable).");
Return True if all elements in this set are found in other iterable.");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use other() as a callable?

I just want to explain that the parameter other is an iterable :) Perhaps it would be better to replace other with iterable? 🤔

serhiy-storchaka
serhiy-storchaka reviewed Jan 26, 2024
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation in Doc/library/stdtypes.rst is short enough to be used as a docstring.

@CharlieZhao95
Copy link
Contributor Author

The documentation in Doc/library/stdtypes.rst is short enough to be used as a docstring.

Thanks. This change looks good. updated! :)

serhiy-storchaka
serhiy-storchaka reviewed Jan 27, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) January 27, 2024 09:29
@serhiy-storchaka serhiy-storchaka merged commit 11c5822 into python:main Jan 27, 2024
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 27, 2024
@miss-islington-app
Copy link

Thanks @CharlieZhao95 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @CharlieZhao95 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
@CharlieZhao95 @miss-islington
pythongh-113560: Improve docstrings for set.issubset() and set.issupe…
212a71c 
…rset() (pythonGH-113562)

(cherry picked from commit 11c5822)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
@CharlieZhao95 @miss-islington
pythongh-113560: Improve docstrings for set.issubset() and set.issupe…
0babe18 
…rset() (pythonGH-113562)

(cherry picked from commit 11c5822)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
< 8000 /div>
@bedevere-app
Copy link
bedevere-app bot commented Jan 27, 2024

GH-114643 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 27, 2024
@bedevere-app
Copy link
bedevere-app bot commented Jan 27, 2024

GH-114644 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 27, 2024
serhiy-storchaka pushed a commit that referenced this pull request Jan 27, 2024
@miss-islington @CharlieZhao95
[3.11] gh-113560: Improve docstrings for set.issubset() and set.issup…
2179948 
…erset() (GH-113562) (GH-114643)

(cherry picked from commit 11c5822)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
serhiy-storchaka pushed a commit that referenced this pull request Jan 27, 2024
@miss-islington @CharlieZhao95
[3.12] gh-113560: Improve docstrings for set.issubset() and set.issup…
5c21f3d 
…erset() (GH-113562) (GH-114644)

(cherry picked from commit 11c5822)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@CharlieZhao95 @aisk
pythongh-113560: Improve docstrings for set.issubset() and set.issupe…
06c9713 
…rset() (pythonGH-113562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharlieZhao95 @serhiy-storchaka @sobolevn @AlexWaygood
0