8000 [3.11] gh-113188: Fix shutil.copymode() and shutil.copystat() on Windows (GH-113285) by miss-islington · Pull Request #113426 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.11] gh-113188: Fix shutil.copymode() and shutil.copystat() on Windows (GH-113285) #113426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2023
Merged

[3.11] gh-113188: Fix shutil.copymode() and shutil.copystat() on Windows (GH-113285) #113426

merged 1 commit into from
Dec 23, 2023

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Dec 23, 2023 •
edited by bedevere-app bot
Loading

Previously they worked differenly if dst is a symbolic link:
they modified the permission bits of dst itself rather than the file
it points to if follow_symlinks is true or src is not a symbolic link,
and did nothing if follow_symlinks is false and src is a symbolic link.
(cherry picked from commit c7874bb)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

@serhiy-storchaka @miss-islington
[3.12] pythongh-113188: Fix shutil.copymode() and shutil.copystat() o…
1fc462f 
…n Windows (pythonGH-113285)

Previously they worked differenly if dst is a symbolic link:
they modified the permission bits of dst itself rather than the file
it points to if follow_symlinks is true or src is not a symbolic link,
and did nothing if follow_symlinks is false and src is a symbolic link.
(cherry picked from commit c7874bb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Dec 23, 2023
Merged
@bedevere-app bedevere-app bot mentioned this pull request Dec 23, 2023
Closed
@serhiy-storchaka serhiy-storchaka changed the title [3.11] [3.12] gh-113188: Fix shutil.copymode() and shutil.copystat() on Windows (GH-113285) [3.11] gh-113188: Fix shutil.copymode() and shutil.copystat() on Windows (GH-113285) Dec 23, 2023
@serhiy-storchaka serhiy-storchaka merged commit 80b2bad into python:3.11 Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miss-islington @serhiy-storchaka
0