8000 GH-110109: pathlib tests: store base directory as test class attribute by barneygale · Pull Request #113221 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-110109: pathlib tests: store base directory as test class attribute #113221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2023
Merged

GH-110109: pathlib tests: store base directory as test class attribute #113221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
GH-110109: pathlib tests: store base directory as test class attribute 
Store the test base directory as a class attribute named `base` rather than
module constants named `BASE`.

The base directory is a local file path, and therefore not ideally suited
to the pathlib ABC tests. In a future commit we'll change its value in
`test_pathlib_abc.py` such that it points to a totally fictitious path.
  • Loading branch information
@barneygale
barneygale committed Dec 16, 2023
commit 9439422087e2a573d76df06199840471b3394073
Loading
0