8000 gh-112205: Support `@setter` annotation from AC by corona10 · Pull Request #112922 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-112205: Support @setter annotation from AC #112922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 13, 2023
Merged

gh-112205: Support @setter annotation from AC #112922

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
488a127
gh-112205: Support `@setter` annotation from AC
corona10 Dec 10, 2023
384d6c1
Update
corona10 Dec 10, 2023
2a8c3de
Apply suggestions from code review
corona10 Dec 10, 2023
0ffa78b
Address code review
corona10 Dec 10, 2023
8e85ab3
nit
corona10 Dec 10, 2023
f3517f9
Prohibit declaration of return type for `getset`
corona10 Dec 10, 2023
323cfc0
Add test
corona10 Dec 10, 2023
30da0cf
Update Tools/clinic/clinic.py
corona10 Dec 11, 2023
1539d11
Address code review
corona10 Dec 11, 2023
d18cd49
Address code review
corona10 Dec 11, 2023
bc373f6
Apply suggestions from code review
corona10 Dec 13, 2023
0cd047b
Use pattern matching
corona10 Dec 13, 2023
c8a035f
Address code review
corona10 Dec 13, 2023
9c66961
fix test
corona10 Dec 13, 2023
06b1cb1
Add test
corona10 Dec 13, 2023
2510a35
Address code review
corona10 Dec 13, 2023
53777df
Update Lib/test/test_clinic.py
corona10 Dec 13, 2023
61f7215
Fix
corona10 Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review
  • Loading branch information
@corona10
corona10 committed Dec 11, 2023
commit d18cd494ea44c2930552a63a6e017ce6d372fd5e
8 changes: 4 additions & 4 deletions Lib/test/clinic.test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4957,7 +4957,7 @@ Test.property
[clinic start generated code]*/

#if defined(TEST_PROPERTY_GETSETDEF)
# undef TEST_PROPERTY_GETSETTDEF
# undef TEST_PROPERTY_GETSETDEF
# define TEST_PROPERTY_GETSETDEF {"property", (getter)Test_property_get, (setter)Test_property_set, NULL},
#else
# define TEST_PROPERTY_GETSETDEF {"property", (getter)Test_property_get, NULL, NULL},
Expand All @@ -4974,7 +4974,7 @@ Test_property_get(TestObj *self, void *Py_UNUSED(context))

static PyObject *
Test_property_get_impl(TestObj *self)
/*[clinic end generated code: output=c7f18e7848b00cfa input=2d92b3449fbc7d2b]*/
/*[clinic end generated code: output=af8140b692e0e2f1 input=2d92b3449fbc7d2b]*/

/*[clinic input]
@setter
Expand All @@ -4985,7 +4985,7 @@ Test.property
# undef TEST_PROPERTY_GETSETDEF
# define TEST_PROPERTY_GETSETDEF {"property", (getter)Test_property_get, (setter)Test_property_set, NULL},
#else
# define TEST_PROPERTY_GETSETTERDEF {"property", NULL, (setter)Test_property_set, NULL},
# define TEST_PROPERTY_GETSETDEF {"property", NULL, (setter)Test_property_set, NULL},
#endif

static int
Expand All @@ -4999,7 +4999,7 @@ Test_property_set(TestObj *self, PyObject *value, void *Py_UNUSED(context))

static int
Test_property_set_impl(TestObj *self, PyObject *value)
/*[clinic end generated code: output=63e670882002b596 input=3bc3f46a23c83a88]*/
/*[clinic end generated code: output=f3eba6487d7550e2 input=3bc3f46a23c83a88]*/

/*[clinic input]
output push
Expand Down
8 changes: 4 additions & 4 deletions Modules/_io/clinic/bufferedio.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Modules/_io/clinic/stringio.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Modules/_io/clinic/textio.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ class CLanguage(Language):
""")
GETTERDEF_PROTOTYPE_DEFINE: Final[str] = normalize_snippet(r"""
#if defined({getset_name}_GETSETDEF)
# undef {getset_name}_GETSETTDEF
# undef {getset_name}_GETSETDEF
# define {getset_name}_GETSETDEF {{"{name}", (getter){getset_basename}_get, (setter){getset_basename}_set, NULL}},
#else
# define {getset_name}_GETSETDEF {{"{name}", (getter){getset_basename}_get, NULL, NULL}},
Expand All @@ -886,7 +886,7 @@ class CLanguage(Language):
# undef {getset_name}_GETSETDEF
# define {getset_name}_GETSETDEF {{"{name}", (getter){getset_basename}_get, (setter){getset_basename}_set, NULL}},
#else
# define {getset_name}_GETSETTERDEF {{"{name}", NULL, (setter){getset_basename}_set, NULL}},
# define {getset_name}_GETSETDEF {{"{name}", NULL, (setter){getset_basename}_set, NULL}},
#endif
""")
METHODDEF_PROTOTYPE_IFNDEF: Final[str] = normalize_snippet("""
Expand Down
0