8000 gh-112736: Refactor del-safe symbol handling in subprocess #112738

freakboy3742 · 2023-12-05T00:56:16Z

Refactors the use of del-safe symbols so that they can be overridden in a cross-platform build environment.

Includes the first references to iOS as a platform identifier (following the acceptance of PEP 730). I was advised in an in-person chat with @ned-deily that as long as tvOS/watchOS patches didn't break anything for existing platforms, they were OK to leave in; but I'm happy to strip those out if you'd prefer.

There's no new tests... because I'm not sure what a test for this would look like. It doesn't change any runtime behavior - the change is really only observable if you're building a crossenv-style environment. I'm open to suggestions for what a test for this would entail.

Issue: del-safe symbols in subprocess module cannot be overwritten in cross-build environment #112736

Lib/subprocess.py

…hon#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

…hon#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.

Refactor delete-safe symbol handling in subprocess.

4f2e1ea

freakboy3742 requested a review from gpshead as a code owner December 5, 2023 00:56

bedevere-app bot added the awaiting review label Dec 5, 2023

bedevere-app bot mentioned this pull request Dec 5, 2023

del-safe symbols in subprocess module cannot be overwritten in cross-build environment #112736

Closed

gpshead self-assigned this Dec 5, 2023

gpshead reviewed Dec 5, 2023

View reviewed changes

Lib/subprocess.py Show resolved Hide resolved

📜🤖 Added by blurb_it.

20e62b9

gpshead approved these changes Dec 5, 2023

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Dec 5, 2023

gpshead merged commit dc824c5 into python:main Dec 5, 2023

bedevere-app bot removed the awaiting merge label Dec 5, 2023

freakboy3742 deleted the subp 8000 rocess-crossenv branch December 5, 2023 04:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

8000 gh-112736: Refactor del-safe symbol handling in subprocess #112738

gh-112736: Refactor del-safe symbol handling in subprocess #112738

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

8000 gh-112736: Refactor del-safe symbol handling in subprocess #112738

gh-112736: Refactor del-safe symbol handling in subprocess #112738

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!