8000 gh-112205: Support @getter annotation from AC by corona10 · Pull Request #112396 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-112205: Support @getter annotation from AC #112396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 30, 2023
Merged

gh-112205: Support @getter annotation from AC #112396

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
72d9018
gh-112205: Support @getter annotation from AC
corona10 Nov 25, 2023
ea83973
Update define macro
corona10 Nov 25, 2023
969adf9
Apply suggestions from code review
corona10 Nov 25, 2023
716b8d9
nit
corona10 Nov 25, 2023
c5fe2b2
Add test case
corona10 Nov 25, 2023
2d9800d
Add test case
corona10 Nov 25, 2023
442c575
Clean up
corona10 Nov 25, 2023
e0fb271
Update Tools/clinic/clinic.py
corona10 Nov 25, 2023
0778eb7
Update logic
corona10 Nov 25, 2023
d5b1751
Update
corona10 Nov 25, 2023
7f4bfa8
Clean up
corona10 Nov 25, 2023
fe46de0
Update Tools/clinic/clinic.py
corona10 Nov 27, 2023
0892d0d
Address code review
corona10 Nov 27, 2023
769f6cd
Address code review
corona10 Nov 28, 2023
dde933e
Address code review
corona10 Nov 28, 2023
d381b5e
Change template key
corona10 Nov 28, 2023
351ba08
Use Py_UNUSED for context
corona10 Nov 28, 2023
f53a035
Update test
corona10 Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review
  • Loading branch information
@corona10
corona10 committed Nov 28, 2023
commit dde933e3e4d73ceb7ea00a876303c8908ca795c5
4 changes: 2 additions & 2 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ class CLanguage(Language):
""")
GETTERDEF_PROTOTYPE_DEFINE: Final[str] = normalize_snippet(r"""
#define {methoddef_name} \
{{"{name}", {methoddef_cast}{c_basename}{methoddef_cast_end}, NULL, NULL}},
{{"{name}", (getter){c_basename}, NULL, NULL}},
""")
METHODDEF_PROTOTYPE_IFNDEF: Final[str] = normalize_snippet("""
#ifndef {methoddef_name}
Expand Down Expand Up @@ -1686,7 +1686,7 @@ def parser_body(
if flags in ('METH_NOARGS', 'METH_O', 'METH_VARARGS'):
methoddef_cast = "(PyCFunction)"
elif f.kind is GETTER:
methoddef_cast = "(getter)"
methoddef_cast = "" # This should end up unused
elif limited_capi:
methoddef_cast = "(PyCFunction)(void(*)(void))"
else:
Expand Down
0