8000 gh-112319: Allow special protocol members by randolf-scholz · Pull Request #112340 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-112319: Allow special protocol members #112340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

gh-112319: Allow special protocol members #112340

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
36b59cb
wip reworked setting __protocol_attrs__
randolf-scholz Nov 23, 2023
9147fd1
Merge branch 'main' into rework_protocol_attrs
randolf-scholz Nov 23, 2023
b9d150d
removed remnant code
randolf-scholz Nov 23, 2023
f7f9a90
Update Lib/typing.py
randolf-scholz Nov 23, 2023
a55ac9b
Update Lib/typing.py
randolf-scholz Nov 23, 2023
3686d11
Apply suggestions from code review
AlexWaygood Nov 23, 2023
8000 d9c4c3c
reverted typeerror context
randolf-scholz Nov 23, 2023
51bf221
reverted order in and check
randolf-scholz Nov 23, 2023
36706a6
Update Lib/typing.py
randolf-scholz Nov 23, 2023
342afda
Update Lib/typing.py
randolf-scholz Nov 23, 2023
14c2c91
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reverted typeerror context
  • Loading branch information
@randolf-scholz
randolf-scholz committed Nov 23, 2023
commit d9c4c3c8c3214f3ade1b0c143fa359e5996a1374
3 changes: 1 addition & 2 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,8 +1885,7 @@ def __subclasscheck__(cls, other):
and cls.__dict__.get("__subclasshook__") is _proto_hook
):
raise TypeError(
f"Protocols with non-method members don't support issubclass()."
f" Non-method members: {cls.__protocol_attrs__}."
"Protocols with non-method members don't support issubclass()"
)
if not getattr(cls, '_is_runtime_protocol', False):
raise TypeError(
Expand Down
0