8000 Tweak my interests (and Mark Shannon's :-) in CODEOWNERS by gvanrossum · Pull Request #112206 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Tweak my interests (and Mark Shannon's :-) in CODEOWNERS #112206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2023
Merged

Tweak my interests (and Mark Shannon's :-) in CODEOWNERS #112206

merged 1 commit into from
Nov 17, 2023

Conversation

gvanrossum
Copy link
Member

No description provided.

@gvanrossum gvanrossum enabled auto-merge (squash) November 17, 2023 16:28
@gvanrossum gvanrossum merged commit 25538c7 into python:main Nov 17, 2023
AlexWaygood
AlexWaygood reviewed Nov 17, 2023
View reviewed changes
.github/CODEOWNERS
@@ -28,14 +28,17 @@ Objects/type* @markshannon
Objects/codeobject.c @markshannon
Objects/frameobject.c @markshannon
Objects/call.c @markshannon
Python/ceval.c @markshannon
Python/ceval*.[ch] @markshannon @gvanrossum
Copy link
Member
@AlexWaygood AlexWaygood Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub now says "This CODEOWNERS file contains errors" because of this line :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry. Do you know what’s wrong? I am AFK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a Google :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's this:

Warning: There are some syntax rules for gitignore files that do not work in CODEOWNERS files:

  • Escaping a pattern starting with # using \ so it is treated as a pattern and not a comment
  • Using ! to negate a pattern
  • Using [ ] to define a character range

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a PR to fix it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed #112210

@AlexWaygood AlexWaygood mentioned this pull request Nov 17, 2023
Merged
@gvanrossum gvanrossum deleted the code-owners branch November 17, 2023 18:56
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@gvanrossum @aisk
Tweak my interests (and Mark Shannon's :-) in CODEOWNERS (python#112206)
0449a61
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@gvanrossum @Glyphack
Tweak my interests (and Mark Shannon's :-) in CODEOWNERS (python#112206)
1469f20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvanrossum @AlexWaygood
0