8000 PEP 737: gh-111696: Add type.__fully_qualified_name__ attribute by vstinner · Pull Request #112133 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

PEP 737: gh-111696: Add type.__fully_qualified_name__ attribute #112133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

PEP 737: gh-111696: Add type.__fully_qualified_name__ attribute #112133

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d5e8a37
gh-111696: Add type.__fullyqualname__ attribute
vstinner Nov 15, 2023
82dd956
Use type.__fullyqualname__ attribute
vstinner Nov 16, 2023
76dcfd5
Rename the attribute to __fully_qualified_name__
vstinner Nov 16, 2023
36cf2a9
Doc: Add "fully qualified name" term to the glossary
vstinner Nov 17, 2023
266a8e5
Add tests on more types: built-in and types
vstinner Nov 17, 2023
e63c937
Fix PyType_FromSpec() error handling
vstinner Nov 17, 2023
c79c519
type.__fully_qualified_name__ getter calls PyType_GetFullyQualifiedNa…
vstinner Nov 17, 2023
46fb6df
Fix typo in the doc
vstinner Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PyType_FromSpec() error handling
  • Loading branch information
@vstinner
vstinner committed Nov 17, 2023
commit e63c93730d73f671064c1791958bd7c6c8a3a739
6 changes: 3 additions & 3 deletions Modules/_testcapimodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ test_get_type_name(PyObject *self, PyObject *Py_UNUSED(ignored))

PyObject *HeapTypeNameType = PyType_FromSpec(&HeapTypeNameType_Spec);
if (HeapTypeNameType == NULL) {
Py_RETURN_NONE;
return NULL;
}
tp_name = PyType_GetName((PyTypeObject *)HeapTypeNameType);
assert(PyUnicode_EqualToUTF8(tp_name, "HeapTypeNameType"));
Expand Down Expand Up @@ -620,7 +620,7 @@ test_get_type_qualname(PyObject *self, PyObject *Py_UNUSED(ignored))

PyObject *HeapTypeNameType = PyType_FromSpec(&HeapTypeNameType_Spec);
if (HeapTypeNameType == NULL) {
Py_RETURN_NONE;
return NULL;
}
tp_qualname = PyType_GetQualName((PyTypeObject *)HeapTypeNameType);
assert(PyUnicode_EqualToUTF8(tp_qualname, "HeapTypeNameType"));
Expand Down Expand Up @@ -658,7 +658,7 @@ test_get_type_fullyqualname(PyObject *self, PyObject *Py_UNUSED(ignored))

PyObject *HeapTypeNameType = PyType_FromSpec(&HeapTypeNameType_Spec);
if (HeapTypeNameType == NULL) {
Py_RETURN_NONE;
return NULL;
}
name = PyType_GetFullyQualifiedName((PyTypeObject *)HeapTypeNameType);
assert(PyUnicode_EqualToUTF8(name, "_testcapi.HeapTypeNameType"));
Expand Down
0