Fix bpo-19217: Calling assertEquals for moderately long list takes too long #11204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
reviewed
Dec 18, 2018
|
It looks like this causes a variety of stdlib unittest failures. skimming them most appear to be golden value tests (ugh) of one form or another that need adjusting. They'll need fixing however is deemed appropriate |
|
This PR has several failing tests. I added a few more commits over here to make this ready for merge: |
|
Thanks, closing in favour of #27434, which has a lot more discussion / activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bpo-19217: Calling assertEquals for moderately long list takes too long
Fix https://bugs.python.org/issue19217
Related: #10034
https://bugs.python.org/issue19217