8000 Fix bpo-19217: Calling assertEquals for moderately long list takes too long by srinivasreddy · Pull Request #10034 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix bpo-19217: Calling assertEquals for moderately long list takes too long #10034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix bpo-19217: Calling assertEquals for moderately long list takes too long #10034

wants to merge 1 commit into from

Conversation

srinivasreddy
Copy link
Contributor
@srinivasreddy srinivasreddy commented Oct 22, 2018 •
edited by bedevere-bot
Loading

@srinivasreddy srinivasreddy reopened this Oct 22, 2018
@matrixise
Copy link
Member

@srinivasreddy The title of your PR is wrong, why "Closes" ?

@srinivasreddy srinivasreddy changed the title Closes bpo-19217: Calling assertEquals for moderately long list takes too long Fix bpo-19217: Calling assertEquals for moderately long list takes too long Oct 22, 2018
eamanu
eamanu approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor
@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok for me

@lisroach
Copy link
Contributor
lisroach commented Nov 9, 2018

Is this still adding the header mentioned in the issue:

+++
@@ -1 +1 @@

? I do find that to look odd. Could this be improved?

@eamanu eamanu mentioned this pull request Dec 17, 2018
Closed
@erlend-aasland
Copy link
Contributor

@lisroach Yes, this is still adding the diff header. Could be improved by adding fromfile='expected', tofile='actual' to difflib.unified_diff() in Lib/unittest/case.py and Lib/unittest/test/test_case.py.

Example output:

--- expected
+++ actual
@@ -9997,4 +9997,4 @@
  1,
  1,
  1,
- 1]
+ 2]

@JacekBzdak JacekBzdak mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@srinivasreddy @matrixise @lisroach @erlend-aasland @eamanu @bedevere-bot
0