8000 Bump `ruff` and `sphinx-lint` in pre-commit by sobolevn · Pull Request #112008 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Bump ruff and sphinx-lint in pre-commit #112008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump ruff and sphinx-lint in pre-commit #112008

wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

No description provided.

@hugovk
Copy link
Member
hugovk commented Nov 12, 2023 •
edited
Loading

Any pressing need to bump mypy ruff?

I know we don't need to bump sphinx-lint because I just released it a few minutes ago and it's a bugfix we don't need.

@AlexWaygood
Copy link
Member

I agree with @hugovk -- I think we can probably slow down the rate of version bumps for pre-commit/mypy etc. :)

CPython is a big project with lots of contributors; adding to the number of open PRs unnecessarily creates extra noise and churn for other people trying to keep track of what's going on. In general, I think it's probably okay to bump these every few months rather than every few weeks.

If there's a specific reason to bump a certain dependency sooner, then that's a different question -- e.g. I bumped mypy a few days ago because I knew running mypy on Tools/clinic/ would fail with the latest version of mypy, and I wanted to fix that: #111961. But in general, I think we should slow the pace of these version bumps a bit.

@hugovk
Copy link
Member
hugovk commented Nov 13, 2023

As mentioned elsewhere, I'd like to use https://pre-commit.ci to automate updating (either monthly or quarterly; weekly is too frequent), but it warrants a discussion whether we also want it to autofix PRs.

However, I just checked and we can set autofix_prs to false to prevent that: https://pre-commit.ci/#configuration

@AlexWaygood
Copy link
Member

This is now out of date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
awaiting review skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @hugovk @AlexWaygood
0