8000 gh-111874: Call `__set_name__` on objects that define the method inside a `typing.NamedTuple` class dictionary as part of the creation of that class by AlexWaygood · Pull Request #111876 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-111874: Call __set_name__ on objects that define the method inside a typing.NamedTuple class dictionary as part of the creation of that class #111876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 27, 2023
Merged

gh-111874: Call __set_name__ on objects that define the method inside a typing.NamedTuple class dictionary as part of the creation of that class #111876

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e3b703d
gh-111874: Call `__set_name__` on objects that define the method insi…
AlexWaygood Nov 9, 2023
f053310
fixup news
AlexWaygood Nov 9, 2023
7ccff63
Also add a test for TypedDict classes
AlexWaygood Nov 9, 2023
0d13e83
Merge branch 'namedtuple-setname' of https://github.com/AlexWaygood/c…
AlexWaygood Nov 9, 2023
e4e968a
Revert "Also add a test for TypedDict classes"
AlexWaygood Nov 9, 2023
e0c88f0
Exception -> BaseException
AlexWaygood Nov 13, 2023
d8102fd
Address review (and fix bug)
AlexWaygood Nov 16, 2023
f2a57b2
Update Lib/test/test_typing.py
AlexWaygood Nov 17, 2023
1909fd5
Handle strange exceptions raised on attempting to access `__set_name__`
AlexWaygood Nov 17, 2023
ed53fcb
typo
AlexWaygood Nov 17, 2023
c2c65c6
big comment
AlexWaygood Nov 17, 2023
e79ea37
Revert "big comment"
AlexWaygood Nov 27, 2023
9fd8b6b
Revert "typo"
AlexWaygood Nov 27, 2023
fdab495
Revert "Handle strange exceptions raised on attempting to access `__s…
AlexWaygood Nov 27, 2023
3932d48
Add a test that asserts the correct behaviour
AlexWaygood Nov 27, 2023
3359ff6
Address Serhiy's second review pass
AlexWaygood Nov 27, 2023
ef628da
Merge branch 'main' into namedtuple-setname
AlexWaygood Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "typo" 
This reverts commit ed53fcb.
  • Loading branch information
@AlexWaygood
AlexWaygood committed Nov 27, 2023
commit 9fd8b6b5c1c81422a94f52ed285aade4c2de8441
2 changes: 1 addition & 1 deletion Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7577,7 +7577,7 @@ class NamedTupleClass(NamedTuple):
normal_exception.__notes__[0].replace("NormalClass", "NamedTupleClass")
)

def test_no_exception_raised_if_accessing_set_name_causes_strange_error(self):
def test_exception_raised_if_accessing_set_name_causes_strange_error(self):
class Meta(type):
def __getattribute__(self, attr):
if attr == "__set_name__":
Expand Down
0