-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-111744: Support opcode events in bdb #111834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
c313480
2606580
99ec1e1
a91fe16
10ba295
36fba4c
65a3a76
05072f4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,10 @@ def __init__(self, skip=None): | |
self.breaks = {} | ||
self.fncache = {} | ||
self.frame_trace_lines = {} | ||
self.frame_trace_opcodes = {} | ||
self.frame_returning = None | ||
self.trace_opcodes = False | ||
self.__curframe = None | ||
|
||
self._load_breaks() | ||
|
||
|
@@ -85,6 +88,9 @@ def trace_dispatch(self, frame, event, arg): | |
|
||
The arg parameter depends on the previous event. | ||
""" | ||
|
||
self.__curframe = frame | ||
|
||
if self.quitting: | ||
return # None | ||
if event == 'line': | ||
|
@@ -101,6 +107,8 @@ def trace_dispatch(self, frame, event, arg): | |
return self.trace_dispatch | ||
if event == 'c_return': | ||
return self.trace_dispatch | ||
if event == 'opcode': | ||
return self.dispatch_opcode(frame, arg) | ||
print('bdb.Bdb.dispatch: unknown debugging event:', repr(event)) | ||
return self.trace_dispatch | ||
|
||
|
@@ -187,6 +195,17 @@ def dispatch_exception(self, frame, arg): | |
|
||
return self.trace_dispatch | ||
|
||
def dispatch_opcode(self, frame, arg): | ||
"""Invoke user function and return trace function for opcode event. | ||
If the debugger stops on the current opcode, invoke | ||
self.user_opcode(). Raise BdbQuit if self.quitting is set. | ||
Return self.trace_dispatch to continue tracing in this scope. | ||
""" | ||
if self.stop_here(frame) or self.break_here(frame): | ||
self.user_opcode(frame) | ||
if self.quitting: raise BdbQuit | ||
return self.trace_dispatch | ||
|
||
# Normally derived classes don't override the following | ||
# methods, but they may if they want to redefine the | ||
# definition of stopping and breakpoints. | ||
|
@@ -273,7 +292,21 @@ def user_exception(self, frame, exc_info): | |
"""Called when we stop on an exception.""" | ||
pass | ||
|
||
def _set_stopinfo(self, stopframe, returnframe, stoplineno=0): | ||
def user_opcode(self, frame): | ||
"""Called when we are about to execute an opcode.""" | ||
pass | ||
|
||
def _set_trace_opcodes(self, trace_opcodes): | ||
if trace_opcodes != self.trace_opcodes: | ||
self.trace_opcodes = trace_opcodes | ||
frame = self.__curframe | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And just to jog my memory: But why is it double-underscored again? Do we need the name-mangling? I see There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes the reason for the double-underscore is to avoid the conflict with The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that feels a lot less cryptic and scary. :) Especially considering we already have |
||
while frame is not None: | ||
frame.f_trace_opcodes = trace_opcodes | ||
if frame is self.botframe: | ||
break | ||
frame = frame.f_back | ||
|
||
def _set_stopinfo(self, stopframe, returnframe, stoplineno=0, opcode=False): | ||
"""Set the attributes for stopping. | ||
|
||
If stoplineno is greater than or equal to 0, then stop at line | ||
|
@@ -286,6 +319,21 @@ def _set_stopinfo(self, stopframe, returnframe, stoplineno=0): | |
# stoplineno >= 0 means: stop at line >= the stoplineno | ||
# stoplineno -1 means: don't stop at all | ||
self.stoplineno = stoplineno | ||
if opcode: | ||
# We are stopping at opcode level | ||
self._set_trace_opcodes(True) | ||
else: | ||
self._set_trace_opcodes(False) | ||
gaogaotiantian marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
def _set_caller_tracefunc(self): | ||
# Issue #13183: pdb skips frames after hitting a breakpoint and running | ||
# step commands. | ||
# Restore the trace function in the caller (that may not have been set | ||
# for performance reasons) when returning from the current frame. | ||
if self.frame_returning: | ||
caller_frame = self.frame_returning.f_back | ||
if caller_frame and not caller_frame.f_trace: | ||
caller_frame.f_trace = self.trace_dispatch | ||
|
||
# Derived classes and clients can call the following methods | ||
# to affect the stepping state. | ||
|
@@ -300,16 +348,14 @@ def set_until(self, frame, lineno=None): | |
|
||
def set_step(self): | ||
"""Stop after one line of code.""" | ||
# Issue #13183: pdb skips frames after hitting a breakpoint and running | ||
# step commands. | ||
# Restore the trace function in the caller (that may not have been set | ||
# for performance reasons) when returning from the current frame. | ||
if self.frame_returning: | ||
caller_frame = self.frame_returning.f_back | ||
if caller_frame and not caller_frame.f_trace: | ||
caller_frame.f_trace = self.trace_dispatch | ||
self._set_caller_tracefunc() | ||
self._set_stopinfo(None, None) | ||
|
||
def set_stepinstr(self): | ||
"""Stop before the next instruction.""" | ||
self._set_caller_tracefunc() | ||
self._set_stopinfo(None, None, opcode=True) | ||
|
||
def set_next(self, frame): | ||
"""Stop on the next line in or below the given frame.""" | ||
self._set_stopinfo(frame, None) | ||
|
@@ -329,11 +375,13 @@ def set_trace(self, frame=None): | |
if frame is None: | ||
frame = sys._getframe().f_back | ||
self.reset() | ||
self.__curframe = frame | ||
while frame: | ||
frame.f_trace = self.trace_dispatch | ||
self.botframe = frame | ||
# We need f_trace_liens == True for the debugger to work | ||
self.frame_trace_lines[frame] = frame.f_trace_lines | ||
self.frame_trace_opcodes[frame] = frame.f_trace_opcodes | ||
frame.f_trace_lines = True | ||
frame = frame.f_back | ||
self.set_step() | ||
|
@@ -355,7 +403,10 @@ def set_continue(self): | |
frame = frame.f_back | ||
for frame, prev_trace_lines in self.frame_trace_lines.items(): | ||
frame.f_trace_lines = prev_trace_lines | ||
for frame, prev_trace_opcodes in self.frame_trace_opcodes.items(): | ||
frame.f_trace_opcodes = prev_trace_opcodes | ||
self.frame_trace_lines = {} | ||
self.frame_trace_opcodes = {} | ||
gaogaotiantian marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
def set_quit(self): | ||
"""Set quitting attribute to True. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Support opcode events in :mod:`bdb` |
Uh oh!
There was an error while loading. Please reload this page.