pr feedback fixes

Signed-off-by: kalyanr <kalyan.ben10@live.com>
python · vstinner · Nov 8, 2023 · Oct 31, 2023 · Oct 31, 2023 · Oct 31, 2023
commit 0e340a129c6e66b8ba6c3c15b0ddbdd63c1b8706
diff --git a/Lib/test/test_capi/test_list.py b/Lib/test/test_capi/test_list.py
@@ -91,21 +91,33 @@ def test_list_get_item(self):
         self.assertNotEqual(get_item(lst, 1), 12)
         # CRASHES for out of index: get_item(lst, 3)
         # CRASHES get_item(21, 2)
-        # CRASHES get_item(NULL, 0)
+        # CRASHES get_item(Null,1)
 
 
     def test_list_setitem(self):
-        # Test PyList_SET_ITEM()
+        # Test PyList_SetItem()
         setitem = _testcapi.list_setitem
         lst = [1, 2, 3]
         setitem(lst, 1, 10)
-        self.assertEqual(lst, [1, 10, 3])
+        self.assertEqual(lst[1], 10)
         self.assertRaises(IndexError, setitem, [1], -1, 5)
         self.assertRaises(TypeError, setitem, lst, 1.5, 10)
         self.assertRaises(TypeError, setitem, 23, 'a', 5)
         self.assertRaises(SystemError, setitem, {}, 0, 5)
 
         # CRASHES setitem(NULL, 'a', 5)
+
+    def test_list_set_item(self):
+        # Test PyList_SET_ITEM()
+        set_item = _testcapi.list_set_item
+        lst = [1, 2, 3]
+        set_item(lst, 1, 10)
+        # self.assertEqual(lst[1], 10)
+        # self.assertRaises(IndexError, set_item, [1], -1, 5)
+        # self.assertRaises(TypeError, set_item, lst, 1.5, 10)
+        # self.assertRaises(TypeError, set_item, 23, 'a', 5)
+        # self.assertRaises(SystemError, set_item, {}, 0, 5)
+
 
     def test_list_insert(self):
         # Test PyList_Insert()

diff --git a/Modules/_testcapi/list.c b/Modules/_testcapi/list.c
@@ -69,8 +69,7 @@ list_setitem(PyObject *Py_UNUSED(module), PyObject *args)
     }
     NULLABLE(obj);
     NULLABLE(value);
-    value = Py_XNewRef(value);
-    RETURN_INT(PyList_SetItem(obj, i, value));
+    RETURN_INT(PyList_SetItem(obj, i, Py_XNewRef(value)));
 
 }
 
@@ -84,8 +83,7 @@ list_set_item(PyObject *Py_UNUSED(module), PyObject *args)
     }
     NULLABLE(obj);
     NULLABLE(value);
-    value = Py_XNewRef(value);
-    PyList_SET_ITEM(obj, i, value);
+    PyList_SET_ITEM(obj, i, Py_XNewRef(value));
     Py_RETURN_NONE;
 
 }
@@ -100,8 +98,7 @@ list_insert(PyObject *Py_UNUSED(module), PyObject *args)
     }
     NULLABLE(obj);
     NULLABLE(value);
-    value = Py_XNewRef(value);
-    RETURN_INT(PyList_Insert(obj, where, value));
+    RETURN_INT(PyList_Insert(obj, where, Py_XNewRef(value)));
 
 }
 
@@ -140,8 +137,7 @@ list_setslice(PyObject *Py_UNUSED(module), PyObject *args)
     }
     NULLABLE(obj);
     NULLABLE(value);
-    value = Py_XNewRef(value);
-    return PyList_SetSlice(obj, ilow, ihigh, value);
+    return PyList_SetSlice(obj, ilow, ihigh, Py_XNewRef(value));
 
 }