8000 gh-111343: Fix `itertools` docs: `start` arg is optional for `count` by sobolevn · Pull Request #111344 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-111343: Fix itertools docs: start arg is optional for count #111344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2023
Merged

gh-111343: Fix itertools docs: start arg is optional for count #111344

merged 3 commits into from
Oct 27, 2023

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Oct 26, 2023 •
edited by github-actions bot
Loading

@sobolevn sobolevn requested review from hugovk and AA-Turner October 26, 2023 07:08
@sobolevn sobolevn requested a review from rhettinger as a code owner October 26, 2023 07:08
@bedevere-app bedevere-app bot mentioned this pull request Oct 26, 2023
Closed
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 26, 2023
@rhettinger rhettinger added the needs backport to 3.12 only security fixes label Oct 27, 2023
@rhettinger rhettinger enabled auto-merge (squash) October 27, 2023 04:20
@rhettinger rhettinger merged commit ee2d22f into python:main Oct 27, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 27, 2023
@sobolevn @miss-islington
pythongh-111343: Fix itertools docs: start arg is optional for `c…
02bad51 
…ount` (pythongh-111344)

(cherry picked from commit ee2d22f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Oct 27, 2023

GH-111385 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 27, 2023
@hugovk
Copy link
Member
hugovk commented Oct 27, 2023

Let's also backport to 3.11.

But on the issue, @zware wrote (#111343 (comment)):

[start[, step]] implies that step can only be specified in conjunction with start, which also isn't true.

rhettinger pushed a commit that referenced this pull request Oct 27, 2023
@miss-islington
[3.12] gh-111343: Fix itertools docs: start arg is optional for `…
883233d 
…count` (gh-111344) (gh-111385)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-111343: Fix itertools docs: start arg is optional for `c…
04a1894 
…ount` (pythongh-111344)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-111343: Fix itertools docs: start arg is optional for `c…
6d2bbbd 
…ount` (pythongh-111344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7458
Reviewers

@rhettinger rhettinger rhettinger approved these changes

@skirpichev skirpichev skirpichev approved these changes

@hugovk hugovk Awaiting requested review from hugovk

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @hugovk @rhettinger @skirpichev
0