8000 [3.12] Sync location of `mypy` pin with the `main` branch by art3xa · Pull Request #111317 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.12] Sync location of mypy pin with the main branch #111317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2023
Merged

[3.12] Sync location of mypy pin with the main branch #111317

merged 4 commits into from
Oct 25, 2023

Conversation

art3xa
Copy link
Contributor
@art3xa art3xa commented Oct 25, 2023

Move mypy pin from Tools/clinic/requirements-dev.txt to Tools/requirements-dev.txt

(#111313 (comment))

@bedevere-app bedevere-app bot mentioned this pull request Oct 25, 2023
Merged
AlexWaygood
AlexWaygood requested changes Oct 25, 2023
View reviewed changes
Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You'll also need to change this line to reflect the new location:

cpython/.github/workflows/mypy.yml

Line 38 in 5c4f9a1

- run: pip install -r Tools/clinic/requirements-dev.txt

@bedevere-app
Copy link
bedevere-app bot commented Oct 25, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@AlexWaygood AlexWaygood changed the title [3.12] Move mypy pin (GH-111313) [3.12] Sync location of mypy pin with the main branch Oct 25, 2023
< 8000 svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit">
Fix mypy.yml after move requirements-dev.txt
46af31c
@AlexWaygood
Copy link
Member

I don't think we should be running mypy on Tools/peg_generator/ on the 3.12 branch. It has a mypy.ini file on the 3.12 branch, it's true, but as you can see, mypy doesn't pass for that directory on the 3.12 branch. It only started passing on this directory after certain changes that we made to the main branch (that aren't worth backporting to 3.12).

I'd prefer it if you only changed this line in the mypy.yml file, and left the others as they are :)

cpython/.github/workflows/mypy.yml

Line 38 in 5c4f9a1

- run: pip install -r Tools/clinic/requirements-dev.txt

@art3xa
Copy link
Contributor Author
art3xa commented Oct 25, 2023

I don't think we should be running mypy on Tools/peg_generator/ on the 3.12 branch. It has a mypy.ini file on the 3.12 branch, it's true, but as you can see, mypy doesn't pass for that directory on the 3.12 branch. It only started passing on this directory after certain changes that we made to the main branch (that aren't worth backporting to 3.12).

I'd prefer it if you only changed this line in the mypy.yml file, and left the others as they are :)

cpython/.github/workflows/mypy.yml

Line 38 in 5c4f9a1

- run: pip install -r Tools/clinic/requirements-dev.txt

Yeah, I already saw that I did it for nothing :)

AlexWaygood
AlexWaygood approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) October 25, 2023 12:26
@art3xa
Copy link
Contributor Author
art3xa commented Oct 25, 2023 •
edited
Loading

Thanks!

No problem! Can I also ask, do you have a small easy issue related to python code in any repository?

@AlexWaygood
Copy link
Member

Thanks!

No problem! Can I also ask, do you have a small easy issue related to python code in any repository?

Hmm, not sure :/ You could try looking through the issues with the easy label on the CPython tracker? :)

@AlexWaygood AlexWaygood merged commit 3d67b69 into python:3.12 Oct 25, 2023
@hugovk
Copy link
Member
hugovk commented Oct 25, 2023

There's also some docs ones at #110383

And “easy”, “good first issue” and “help wanted” issues in other Python core repos:

@art3xa
Copy link
Contributor Author
art3xa commented Oct 25, 2023

Thank you so much!)

@AlexWaygood AlexWaygood mentioned this pull reques 84DC t Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art3xa @AlexWaygood @hugovk
0