-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Revert "Fix a code snippet typo in asyncio docs (#108427)" #111271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) Ref: python#108427 (comment)
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2023
…ythonGH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) (cherry picked from commit c7d68f9) Co-authored-by: Zachary Ware <zach@python.org> Ref: https://github.com/python/cpython/pull/108427GH-issuecomment-1777525740
GH-111272 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2023
…ythonGH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) (cherry picked from commit c7d68f9) Co-authored-by: Zachary Ware <zach@python.org> Ref: https://github.com/python/cpython/pull/108427GH-issuecomment-1777525740
GH-111273 is a backport of this pull request to the 3.11 branch. |
zware
added a commit
that referenced
this pull request
Oct 24, 2023
…H-111271) (GH-111272) Revert "Fix a code snippet typo in asyncio docs (GH-108427)" (GH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) (cherry picked from commit c7d68f9) Ref: #108427 (comment) Co-authored-by: Zachary Ware <zach@python.org>
zware
added a commit
that referenced
this pull request
Oct 24, 2023
…H-111271) (GH-111273) Revert "Fix a code snippet typo in asyncio docs (GH-108427)" (GH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) (cherry picked from commit c7d68f9) Ref: #108427 (comment) Co-authored-by: Zachary Ware <zach@python.org>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…honGH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) Ref: python#108427 (comment)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…honGH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) Ref: python#108427 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7f31676.
The change resulted in a tautology and should not have been made. There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)
Ref: #108427 (comment)
📚 Documentation preview 📚: https://cpython-previews--111271.org.readthedocs.build/