8000 Revert "Fix a code snippet typo in asyncio docs (#108427)" by zware · Pull Request #111271 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

Revert "Fix a code snippet typo in asyncio docs (#108427)" #111271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

zware
Copy link
Member
@zware zware commented Oct 24, 2023

This reverts commit 7f31676.

The change resulted in a tautology and should not have been made. There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)

Ref: #108427 (comment)


📚 Documentation preview 📚: https://cpython-previews--111271.org.readthedocs.build/

This reverts commit 7f31676.

The change resulted in a tautology and should not have been made.  There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)

Ref: python#108427 (comment)
@bedevere-app bedevere-app bot added awaiting core review docs Documentation in the Doc dir skip news labels Oct 24, 2023
@zware zware added skip issue needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 24, 2023
@zware zware merged commit c7d68f9 into python:main Oct 24, 2023
@zware zware deleted the revert-7f31676 branch October 24, 2023 16:09
@miss-islington-app
Copy link

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
…ythonGH-111271)

This reverts commit 7f31676.

The change resulted in a tautology and should not have been made.  There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)

(cherry picked from commit c7d68f9)

Co-authored-by: Zachary Ware <zach@python.org>
Ref: https://github.com/python/cpython/pull/108427GH-issuecomment-1777525740
@bedevere-app
Copy link
bedevere-app bot commented Oct 24, 2023

GH-111272 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
…ythonGH-111271)

This reverts commit 7f31676.

The change resulted in a tautology and should not have been made.  There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)

(cherry picked from commit c7d68f9)

Co-authored-by: Zachary Ware <zach@python.org>
Ref: https://github.com/python/cpython/pull/108427GH-issuecomment-1777525740
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 24, 2023
@bedevere-app
Copy link
bedevere-app bot commented Oct 24, 2023

GH-111273 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 24, 2023
zware added a commit that referenced this pull request Oct 24, 2023
…H-111271) (GH-111272)

Revert "Fix a code snippet typo in asyncio docs (GH-108427)" (GH-111271)

This reverts commit 7f31676.

The change resulted in a tautology and should not have been made.  There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)

(cherry picked from commit c7d68f9)


Ref: #108427 (comment)

Co-authored-by: Zachary Ware <zach@python.org>
zware added a commit that referenced this pull request Oct 24, 2023
…H-111271) (GH-111273)

Revert "Fix a code snippet typo in asyncio docs (GH-108427)" (GH-111271)

This reverts commit 7f31676.

The change resulted in a tautology and should not have been made.  There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)

(cherry picked from commit c7d68f9)


Ref: #108427 (comment)

Co-authored-by: Zachary Ware <zach@python.org>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…honGH-111271)

This reverts commit 7f31676.

The change resulted in a tautology and should not have been made.  There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)

Ref: python#108427 (comment)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…honGH-111271)

This reverts commit 7f31676.

The change resulted in a tautology and should not have been made.  There
may be an opportunity for additional clarity in this section, but this
change wasn't it :)

Ref: python#108427 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0