10000 gh-111233: Fix `selectmodule.c` not checking for errors when initializing by sobolevn · Pull Request #111234 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-111233: Fix selectmodule.c not checking for errors when initializing #111234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2023
Merged

gh-111233: Fix selectmodule.c not checking for errors when initializing #111234

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e7a5a1
gh-111233: Fix `selectmodule.c` not checking for errors when initiali…
sobolevn Oct 23, 2023
3c4d3bf
Address review
sobolevn Oct 24, 2023
45dc20d
Style nit
erlend-aasland Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Oct 24, 2023
commit 3c4d3bf95faed58d3e3baec7d5d862f1d6b64d3f
20 changes: 12 additions & 8 deletions Modules/selectmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2444,10 +2444,12 @@ _select_exec(PyObject *m)
return -1;
}

#define ADD_INT(val) \
if (PyModule_AddIntConstant((m), #val, (val)) < 0) { \
return -1; \
}
#define ADD_INT(VAL) \
do { \
if (PyModule_AddIntConstant((m), #VAL, (VAL)) < 0) { \
return -1; \
} \
} while (0)

#ifdef PIPE_BUF
#ifdef HAVE_BROKEN_PIPE_BUF
Expand Down Expand Up @@ -2561,10 +2563,12 @@ _select_exec(PyObject *m)

#undef ADD_INT

#define ADD_INT_CONST(name, val) \
if (PyModule_AddIntConstant(m, name, val) < 0) { \
return -1; \
}
#define ADD_INT_CONST(NAME, VAL) \
do { \
if (PyModule_AddIntConstant(m, NAME, VAL) < 0) { \
return -1; \
} \
} while (0)

#ifdef HAVE_KQUEUE
state->kqueue_event_Type = (PyTypeObject *)PyType_FromModuleAndSpec(
Expand Down
0