Address review comments.

python · serhiy-storchaka · May 28, 2025 · Sep 20, 2023 · Oct 18, 2023 · Oct 18, 2023
commit 154a82a5d65402defa6e028dd333846dd2384cd8
diff --git a/Doc/c-api/sys.rst b/Doc/c-api/sys.rst
@@ -260,8 +260,10 @@ accessible to C code.  They all work with the current interpreter thread's
 
 .. c:function:: PyObject *PySys_GetAttr(PyObject *name)
 
-   Get the attribute *name* of the :mod:`sys` module. Return a :term:`strong reference`.
-   Raise :exc:`RuntimeError` and return ``NULL`` if it does not exist.
+   Get the attribute *name* of the :mod:`sys` module.
+   Return a :term:`strong reference`.
+   Raise :exc:`RuntimeError` and return ``NULL`` if it does not exist or
+   if the :mod:`sys` module cannot be found.
 
    If the non-existing object should not be treated as a failure, you can use
    :c:func:`PySys_GetOptionalAttr` instead.
@@ -279,21 +281,21 @@ accessible to C code.  They all work with the current interpreter thread's
 
    .. versionadded:: next
 
-.. c:function:: int PySys_GetOptionalAttr(PyObject *name, PyObject **result);
+.. c:function:: int PySys_GetOptionalAttr(PyObject *name, PyObject **result)
 
    Variant of :c:func:`PySys_GetAttr` which doesn't raise
    exception if the object does not exist.
 
-   If the object exists, set *\*result* to a new :term:`strong reference`
-   to the object and return ``1``.
-   If the object does not exist, set *\*result* to ``NULL`` and return ``0``,
-   without setting an exception.
-   If other error occurred, set an exception, set *\*result* to ``NULL`` and
-   return ``-1``.
+   * Set *\*result* to a new :term:`strong reference` to the object and
+     return ``1`` if the object exists.
+   * Set *\*result* to ``NULL`` and return ``0`` without setting an exception
+     if the object does not exist.
+   * Set an exception, set *\*result* to ``NULL``, and return ``-1``,
+     if an error occurred.
 
    .. versionadded:: next
 
-.. c:function:: int PySys_GetOptionalAttrString(const char *name, PyObject **result);
+.. c:function:: int PySys_GetOptionalAttrString(const char *name, PyObject **result)
 
    This is the same as :c:func:`PySys_GetOptionalAttr`, but *name* is
    specified as a :c:expr:`const char*` UTF-8 encoded bytes string,

diff --git a/Include/cpython/sysmodule.h b/Include/cpython/sysmodule.h
@@ -80,8 +80,8 @@ PySys_GetAttr(PyObject *name)
 {
     if (!PyUnicode_Check(name)) {
         PyErr_Format(PyExc_TypeError,
-                     "attribute name must be string, not '%.200s'",
-                     Py_TYPE(name)->tp_name);
+                     "attribute name must be string, not '%T'",
+                     name);
         return NULL;
     }
     PyThreadState *tstate = _PyThreadState_GET();
@@ -118,8 +118,8 @@ PySys_GetOptionalAttr(PyObject *name, PyObject **value)
 {
     if (!PyUnicode_Check(name)) {
         PyErr_Format(PyExc_TypeError,
-                     "attribute name must be string, not '%.200s'",
-                     Py_TYPE(name)->tp_name);
+                     "attribute name must be string, not '%T'",
+                     name);
         *value = NULL;
         return -1;
     }