gh-110722: Add PYTHON_PRESITE to import a module before site.py is run #110769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before site.py is run This is only available --with-pydebug.
vstinner
reviewed
Oct 12, 2023
There was a problem hiding this comment.
It may be interesting to make this feature to release build.
For the doc, I suggest to replace package.module with module. You can explain in the doc that the argument can be a module of a package, with an example. I don't know.
Overall, the implementation looks correct.
ambv
commented
Oct 13, 2023
gpshead
reviewed
Oct 13, 2023
vstinner
reviewed
Oct 14, 2023
There was a problem hiding this comment.
I'm fine with the C implementation and the overall feature, I just have some remarks on the doc.
I suggest to replace site.py with the site module. In Sphinx, you can even create a link if you want:
the :mod:`site` module
The presite module is imported, it's exactly run. But I'm fine with run_presite name :-) Well, in fact, it can be seed as being "run" ;-)
|
Congrats! |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
MrPiNkY2022
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only available --with-pydebug.
📚 Documentation preview 📚: https://cpython-previews--110769.org.readthedocs.build/