8000 gh-110392: Fix tty functions by serhiy-storchaka · Pull Request #110642 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-110392: Fix tty functions #110642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2023
Merged

gh-110392: Fix tty functions #110642

merged 1 commit into from
Oct 14, 2023

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Oct 10, 2023 •
edited by bedevere-app bot
Loading
  • tty.setraw() and tty.setcbreak() previously returned partially modified list of the original tty attributes. Now they return the correct list of the original tty attributes
  • tty.cfmakeraw() and tty.cfmakecbreak() now make a copy of the list of special characters before modifying it.

@serhiy-storchaka
pythongh-110392: Fix tty functions
2a4f260 
* tty.setraw() and tty.setcbreak() previously returned partially modified
  list of the original tty attributes. Now they return the correct list of
  the original tty attributes

* tty.cfmakeraw() and tty.cfmakecbreak() now make a copy of the list of
  special characters before modifying it.
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Oct 10, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2023
Closed
@serhiy-storchaka serhiy-storchaka merged commit 84e2096 into python:main Oct 14, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the tty-cfmakeraw-cfmakecbreak branch October 14, 2023 05:50
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2023
@serhiy-storchaka 8000 @miss-islington
pythongh-110392: Fix tty functions (pythonGH-110642)
f1c5933 
* tty.setraw() and tty.setcbreak() previously returned partially modified
  list of the original tty attributes. Now they return the correct list of
  the original tty attributes

* tty.cfmakeraw() and tty.cfmakecbreak() now make a copy of the list of
  special characters before modifying it.
(cherry picked from commit 84e2096)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Oct 14, 2023

GH-110853 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 14, 2023
serhiy-storchaka added a commit that referenced this pull request Oct 14, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-110392: Fix tty functions (GH-110642) (GH-110853)
0164832 
* tty.setraw() and tty.setcbreak() previously returned partially modified
  list of the original tty attributes. Now they return the correct list of
  the original tty attributes

* tty.cfmakeraw() and tty.cfmakecbreak() now make a copy of the list of
  special characters before modifying it.

(cherry picked from commit 84e2096)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-110392: Fix tty functions (pythonGH-110642)
9adf682 
* tty.setraw() and tty.setcbreak() previously returned partially modified
  list of the original tty attributes. Now they return the correct list of
  the original tty attributes

* tty.cfmakeraw() and tty.cfmakecbreak() now make a copy of the list of
  special characters before modifying it.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-110392: Fix tty functions (pythonGH-110642)
a22e2dd 
* tty.setraw() and tty.setcbreak() previously returned partially modified
  list of the original tty attributes. Now they return the correct list of
  the original tty attributes

* tty.cfmakeraw() and tty.cfmakecbreak() now make a copy of the list of
  special characters before modifying it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @miss-islington @gpshead
0