8000 gh-76785: Make interpreters.*Channel Objects Shareable by ericsnowcurrently · Pull Request #110607 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-76785: Make interpreters.*Channel Objects Shareable #110607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023
+5 −2
Merged

gh-76785: Make interpreters.*Channel Objects Shareable #110607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8000
2 changes: 1 addition & 1 deletion Lib/test/support/interpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,4 +241,4 @@ def close(self):


# XXX This is causing leaks (gh-110318):
#_channels._register_end_types(SendChannel, RecvChannel)
_channels._register_end_types(SendChannel, RecvChannel)
1 change: 0 additions & 1 deletion Lib/test/test_interpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,6 @@ def test_list_all(self):
after = set(interpreters.list_all_channels())
self.assertEqual(after, created)

@unittest.expectedFailure # See gh-110318:
def test_shareable(self):
rch, sch = interpreters.create_channel()

Expand Down
4 changes: 4 additions & 0 deletions Modules/_xxinterpchannelsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,10 @@ _get_current_module_state(void)
static int
traverse_module_state(module_state *state, visitproc visit, void *arg)
{
/* external types */
Py_VISIT(state->send_channel_type);
Py_VISIT(state->recv_channel_type);

/* heap types */
Py_VISIT(state->ChannelIDType);
Py_VISIT(state->XIBufferViewType);
Expand Down
0