8000 gh-108277: Fix test_os TimerfdTests by vstinner · Pull Request #110515 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-108277: Fix test_os TimerfdTests #110515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2023
Merged

gh-108277: Fix test_os TimerfdTests #110515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3929,6 +3929,10 @@ def test_eventfd_select(self):
@unittest.skipUnless(hasattr(os, 'timerfd_create'), 'requires os.timerfd_create')
@support.requires_linux_version(2, 6, 30)
class TimerfdTests(unittest.TestCase):
# Tolerate a difference of 50 us
CLOCK_RES_NS = 50_000
CLOCK_RES = CLOCK_RES_NS * 1e-9

def timerfd_create(self, *args, **kwargs):
fd = os.timerfd_create(*args, **kwargs)
self.assertGreaterEqual(fd, 0)
Expand Down Expand Up @@ -3982,9 +3986,13 @@ def test_timerfd_negative(self):
one_sec_in_nsec = 10**9
fd = self.timerfd_create(time.CLOCK_REALTIME)

test_flags = [0, os.TFD_TIMER_ABSTIME]
if hasattr(os, 'TFD_TIMER_CANCEL_ON_SET'):
test_flags.append(os.TFD_TIMER_ABSTIME | os.TFD_TIMER_CANCEL_ON_SET)

# Any of 'initial' and 'interval' is negative value.
for initial, interval in ( (-1, 0), (1, -1), (-1, -1), (-0.1, 0), (1, -0.1), (-0.1, -0.1)):
for flags in (0, os.TFD_TIMER_ABSTIME, os.TFD_TIMER_ABSTIME|os.TFD_TIMER_CANCEL_ON_SET):
for flags in test_flags:
with self.subTest(flags=flags, initial=initial, interval=interval):
with self.assertRaises(OSError) as context:
_, _ = os.timerfd_settime(fd, flags=flags, initial=initial, interval=interval)
Expand Down Expand Up @@ -4055,7 +4063,7 @@ def test_timerfd_TFD_TIMER_ABSTIME(self):
t = time.perf_counter() - t
self.assertEqual(count_signaled, 1)

self.assertGreater(t, offset)
self.assertGreater(t, offset - self.CLOCK_RES)

def test_timerfd_select(self):
size = 8 # read 8 bytes
Expand Down Expand Up @@ -4208,7 +4216,7 @@ def test_timerfd_ns_TFD_TIMER_ABSTIME(self):
t = time.perf_counter_ns() - t
self.assertEqual(count_signaled, 1)

self.assertGreater(t, offset_ns)
self.assertGreater(t, offset_ns - self.CLOCK_RES_NS)

def test_timerfd_ns_select(self):
size = 8 # read 8 bytes
Expand Down
0