10000 gh-90095: Make .pdbrc work properly and add some reasonable tests by gaogaotiantian · Pull Request #110496 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-90095: Make .pdbrc work properly and add some reasonable tests #110496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 11, 2024
Merged

gh-90095: Make .pdbrc work properly and add some reasonable tests #110496

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fdd36d2
Make .pdbrc work properly and add some reasonable tests
gaogaotiantian Oct 7, 2023
3f3cd7d
Add comment test
gaogaotiantian Oct 7, 2023
33225ee
Fix homesave issue
gaogaotiantian Oct 7, 2023
2e1bc86
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 7, 2023
78f953a
Merge branch 'main' into pdb-rc-commands
gaogaotiantian Oct 9, 2023
6761844
Merge branch 'main' into pdb-rc-commands
gaogaotiantian Feb 8, 2024
e66eb76
Revert emplty line change
gaogaotiantian Feb 8, 2024
f07e770
Fix a bare return
gaogaotiantian Feb 8, 2024
0b1c0e8
Clean up logic for remove_home
gaogaotiantian Mar 11, 2024
75d1361
Check homesave to restore HOME
gaogaotiantian Mar 11, 2024
a5187a5
Merge branch 'main' into pdb-rc-commands
iritkatriel Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check homesave to restore HOME
  • Loading branch information
@gaogaotiantian
gaogaotiantian authored Mar 11, 2024
commit 75d1361e7004b9d733a4cfc619dd0c467093d955
3 changes: 2 additions & 1 deletion Lib/test/test_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2632,12 +2632,13 @@ def run_pdb_script(self, script, commands,
self.addCleanup(os_helper.unlink, '.pdbrc')
self.addCleanup(os_helper.unlink, filename)

homesave = None
if remove_home:
homesave = os.environ.pop('HOME', None)
try:
stdout, stderr = self._run_pdb([filename], commands, expected_returncode, extra_env)
finally:
if remove_home:
if homesave is not None:
os.environ['HOME'] = homesave
return stdout, stderr

Expand Down
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0