8000 gh-76785: Print the Traceback from Interpreter.run() by ericsnowcurrently · Pull Request #110322 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-76785: Print the Traceback from Interpreter.run() #110322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2023
Merged

gh-76785: Print the Traceback from Interpreter.run() #110322

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
556bee4
Print the traceback.
ericsnowcurrently Sep 18, 2023
cdb517d
Only print the traceback if there was an exception.
ericsnowcurrently Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Only print the traceback if there was an exception.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Oct 4, 2023
commit cdb517d5ee1d9355f5de39a3f5c9c42f2e07bbab
12 changes: 7 additions & 5 deletions Modules/_xxsubinterpretersmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,11 +450,13 @@ _run_script(PyInterpreterState *interp, const char *codestr,
"RunFailedError: script raised an uncaught exception (%s)",
failure);
}
// XXX Instead, store the rendered traceback on sharedexc,
// attach it to the exception when applied,
// and teach PyErr_Display() to print it.
PyErr_Display(NULL, excval, NULL);
Py_XDECREF(excval);
if (excval != NULL) {
// XXX Instead, store the rendered traceback on sharedexc,
// attach it to the exception when applied,
// and teach PyErr_Display() to print it.
PyErr_Display(NULL, excval, NULL);
Py_DECREF(excval);
}
if (errcode != ERR_ALREADY_RUNNING) {
_PyInterpreterState_SetNotRunningMain(interp);
}
Expand Down
0