8000 gh-110289: C API: Add PyUnicode_EqualToUTF8() function by serhiy-storchaka · Pull Request #110297 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-110289: C API: Add PyUnicode_EqualToUTF8() function #110297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 11, 2023
Merged

gh-110289: C API: Add PyUnicode_EqualToUTF8() function #110297

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d39945e
gh-110289: C API: Add PyUnicode_EqualToString() function
serhiy-storchaka Oct 3, 2023
4793161
Add tests and address review comments.
serhiy-storchaka Oct 3, 2023
8b24911
Merge branch 'main' into capi-PyUnicode_EqualToString
serhiy-storchaka Oct 3, 2023
c55f9ac
Apply suggestions from code review
serhiy-storchaka Oct 4, 2023
bdf2f1e
Address some of review comments and test the UTF-8 cache.
serhiy-storchaka Oct 4, 2023
7223c14
Address review comments.
serhiy-storchaka Oct 4, 2023
b271327
Apply suggestions from code review
serhiy-storchaka Oct 4, 2023
6f26ad6
Remove trailing spaces.
serhiy-storchaka Oct 4, 2023
dd124b8
Apply suggestions from code review
serhiy-storchaka Oct 4, 2023
76b9177
Use "z#" instead of "|y#".
serhiy-storchaka Oct 4, 2023
ee5781d
Apply suggestions from code review
serhiy-storchaka Oct 5, 2023
1a4eb7b
Add PyUnicode_EqualToUTF8AndSize().
serhiy-storchaka Oct 6, 2023
b124377
Apply suggestions from code review
serhiy-storchaka Oct 7, 2023
029f1a0
Add more parentheses.
serhiy-storchaka Oct 7, 2023
be2ffe8
Remove redundant arguments.
serhiy-storchaka Oct 7, 2023
29b26f7
Merge branch 'main' into capi-PyUnicode_EqualToString
serhiy-storchaka Oct 7, 2023
78de49d
Turn docstrings into comments.
serhiy-storchaka Oct 10, 2023
fc79d5e
Merge branch 'main' into capi-PyUnicode_EqualToString
serhiy-storchaka Oct 10, 2023
19ad126
Add tests for empty strings.
serhiy-storchaka Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant arguments.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Oct 7, 2023
commit be2ffe844a5f274168f2f7e554f8e1f745e83cb9
4 changes: 2 additions & 2 deletions Lib/test/test_capi/test_unicode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,8 +1372,8 @@ def test_equaltoutf8andsize(self):
self.assertEqual(equaltoutf8andsize(s2, b, len(b) - 1), 0)

# embedded null chars/bytes
self.assertEqual(equaltoutf8andsize('abc\0def', b'abc\0def', 7), 1)
self.assertEqual(equaltoutf8andsize('abc\0def\0', b'abc\0def\0', 8), 1)
self.assertEqual(equaltoutf8andsize('abc\0def', b'abc\0def'), 1)
self.assertEqual(equaltoutf8andsize('abc\0def\0', b'abc\0def\0'), 1)

# Surrogate characters are always treated as not equal
self.assertEqual(equaltoutf8andsize('\udcfe',
Expand Down
0