8000 gh-109864: Make test_gettext tests order independent by serhiy-storchaka · Pull Request #109866 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-109864: Make test_gettext tests order independent #109866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2023
Merged

gh-109864: Make test_gettext tests order independent #109866

merged 1 commit into from
Oct 7, 2023

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Sep 25, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 25, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 25, 2023
Closed
@serhiy-storchaka serhiy-storchaka merged commit 1aad4fc into python:main Oct 7, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test_gettext branch October 7, 2023 13:00
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2023
@serhiy-storchaka @miss-islington
pythongh-109864: Make test_gettext tests order independent (pythonGH-…
d78aa9e 
…109866)

(cherry picked from commit 1aad4fc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Oct 7, 2023

GH-110502 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 7, 2023
@bedevere-app
Copy link
bedevere-app bot commented Oct 7, 2023

GH-110503 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2023
@serhiy-storchaka @miss-islington
pythongh-109864: Make test_gettext tests order independent (pythonGH-…
60514d6 
…109866)

(cherry picked from commit 1aad4fc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Oct 7, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-109864: Make test_gettext tests order independent (GH-109866)…
6823212 
… (GH-110503)

(cherry picked from commit 1aad4fc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Oct 7, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-109864: Make test_gettext tests order independent (GH-109866)…
6430ca5 
… (GH-110502)

(cherry picked from commit 1aad4fc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Bigmem 3.x has failed when building commit 1aad4fc.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1079/builds/2460) and take a look at the build logs.
  4. Check if the failure is related to this commit (1aad4fc) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1079/builds/2460

Failed tests:

  • test_os

Failed subtests:

  • test_listmounts - test.test_os.Win32ListdriveTests.test_listmounts

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\test\test_os.py", line 2713, in test_listmounts
    self.assertSetEqual(
AssertionError: Items in the first set but not the second:
'R:\\'

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-109864: Make test_gettext tests order independent (pythonGH-…
beb7064 
…109866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @miss-islington @bedevere-bot
0