8000 Fix argument ordering of embuilder command by OmniTroid · Pull Request #109863 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix argument ordering of embuilder command #109863

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix argument ordering of embuilder command #109863

merged 2 commits into from
Sep 26, 2023

Conversation

OmniTroid
Copy link
Contributor

No description provided.

@ghost
Copy link
ghost commented Sep 25, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link
bedevere-app bot commented Sep 25, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@AA-Turner
Copy link
Member

Please can you explain this change?

A

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news build The build process and cross-build labels Sep 25, 2023
@OmniTroid
Copy link
Contributor Author

Yes, the existing command
embuilder build --pic zlib bzip2 MINIMAL_PIC
fails with
embuilder.py: error: unrecognized arguments: zlib bzip2 MINIMAL_PIC
because the arguments are passed in the wrong order. The correct usage is as follows:

usage: embuilder.py [-h] [--lto] [--lto=thin] [--pic] [--force] [--verbose] [--wasm64]
                    {build,clear,rebuild} [targets ...]

Which means the correct order of arguments is
embuilder --pic build zlib bzip2 MINIMAL_PIC

@brettcannon brettcannon self-assigned this Sep 26, 2023
@brettcannon brettcannon merged commit 4390c13 into python:main Sep 26, 2023
@OmniTroid OmniTroid deleted the wasm-readme-embuilder branch September 27, 2023 07:03
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@OmniTroid @csm10495
Fix argument ordering of embuilder command documented in `Tools/wasm/…
aef7403 
…README.md` (pythonGH-109863)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@OmniTroid @Glyphack
Fix argument ordering of embuilder command documented in `Tools/wasm/…
c81268c 
…README.md` (pythonGH-109863)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees

@brettcannon brettcannon

Labels
build The build process and cross-build docs Documentation in the Doc dir OS-wasi skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmniTroid @AA-Turner @brettcannon
0