8000 gh-103615: Use local events for opcode tracing by gaogaotiantian · Pull Request #109472 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-103615: Use local events for opcode tracing #109472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 3, 2023
Merged

gh-103615: Use local events for opcode tracing #109472

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4dd900c
Use local monitoring for opcode trace
gaogaotiantian Sep 15, 2023
dfc5aa6
Remove f_opcode_trace_set and fix a bug
gaogaotiantian Sep 15, 2023
ebf9d02
Remove redundant disable
gaogaotiantian Sep 15, 2023
c2075a4
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 15, 2023
e4f7e97
Add test for setting f_trace_opcodes after settrace
gaogaotiantian Sep 29, 2023
6f7e266
Merge branch 'main' into pep669-opcode-trace
gaogaotiantian Oct 12, 2023
3a8811a
Change error style
gaogaotiantian Oct 24, 2023
5d0a999
Merge branch 'main' into pep669-opcode-trace
markshannon Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change error style
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Oct 24, 2023
commit 3a8811a35fcae6e63ad437679254151247617f52
28 changes: 15 additions & 13 deletions Python/legacy_tracing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,21 +117,23 @@ _PyEval_SetOpcodeTrace(

PyCodeObject *code = (PyCodeObject *)frame->f_frame->f_executable;
_PyMonitoringEventSet events = 0;
if (_PyMonitoring_GetLocalEvents(code, PY_MONITORING_SYS_TRACE_ID, &events) == 0) {
if (enable) {
if (events & (1 << PY_MONITORING_EVENT_INSTRUCTION)) {
return 0;
}
events |= (1 << PY_MONITORING_EVENT_INSTRUCTION);
} else {
if (!(events & (1 << PY_MONITORING_EVENT_INSTRUCTION))) {
return 0;
}
events &= (~(1 << PY_MONITORING_EVENT_INSTRUCTION));

if (_PyMonitoring_GetLocalEvents(code, PY_MONITORING_SYS_TRACE_ID, &events) < 0) {
return -1;
}

if (enable) {
if (events & (1 << PY_MONITORING_EVENT_INSTRUCTION)) {
return 0;
}
events |= (1 << PY_MONITORING_EVENT_INSTRUCTION);
} else {
if (!(events & (1 << PY_MONITORING_EVENT_INSTRUCTION))) {
return 0;
}
return _PyMonitoring_SetLocalEvents(code, PY_MONITORING_SYS_TRACE_ID, events);
events &= (~(1 << PY_MONITORING_EVENT_INSTRUCTION));
}
return -1;
return _PyMonitoring_SetLocalEvents(code, PY_MONITORING_SYS_TRACE_ID, events);
}

static PyObject *
Expand Down
0