10000 gh-109414: Add some basic information about venvs in the introduction. by vsajip · Pull Request #109440 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-109414: Add some basic information about venvs in the introduction. #109440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2023
Merged

gh-109414: Add some basic information about venvs in the introduction. #109440

merged 3 commits into from
Sep 16, 2023

Conversation

vsajip
Copy link
Member
@vsajip vsajip commented Sep 15, 2023 •
edited
Loading

@vsajip vsajip added the docs Documentation in the Doc dir label Sep 15, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 15, 2023
Closed
@vsajip vsajip requested a review from brettcannon September 15, 2023 08:45
vstinner
vstinner reviewed Sep 15, 2023
View reviewed changes
@vstinner
Copy link
Member

I'm using venv as a sandbox to install libraries that I don't want to install system-wide, but your definition implies that.

I'm also using them to modify the code: it's convenient to develop, since changes are "undone" when I remove (and recreate) the venv.

vstinner
vstinner approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made some suggestions, but you can ignore them ;-)

@vsajip @vstinner
Apply suggestions from code review
43a2f95 
Co-authored-by: Victor Stinner <vstinner@python.org>
@vsajip
Copy link
Member Author
vsajip commented Sep 15, 2023

I'm using venv as a sandbox to install libraries that I don't want to install system-wide, but your definition implies that.

I'm also using them to modify the code

Yes, the list isn't meant to be exhaustive 😉

vstinner
vstinner approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the minor updates 😉

@vsajip vsajip merged commit a6846d4 into python:main Sep 16, 2023
@vsajip vsajip deleted the fix-109414 branch September 16, 2023 08:49
@vsajip vsajip added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 16, 2023
@miss-islington
Copy link
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2023
@vsajip @vstinner @miss-islington
pythongh-109414: Add some basic information about venvs in the introd…
0d584d7 
…uction. (pythonGH-109440)

(cherry picked from commit a6846d4)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2023
@vsajip @vstinner @miss-islington
pythongh-109414: Add some basic information about venvs in the introd…
fbe857c 
…uction. (pythonGH-109440)

(cherry picked from commit a6846d4)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Sep 16, 2023

GH-109480 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 16, 2023
@bedevere-app
Copy link
bedevere-app bot commented Sep 16, 2023

GH-109481 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 16, 2023
vsajip pushed a commit that referenced this pull request Sep 16, 2023
@miss-islington
[3.11] gh-109414: Add some basic information about venvs in the intro…
e16a9af 
…duction. (GH-109440) (GH-109480)

(cherry picked from commit a6846d4)
Yhg1s pushed a commit that referenced this pull request Sep 17, 2023
@miss-islington @vsajip @vstinner
[3.12] gh-109414: Add some basic information about venvs in the intro…
6552879 
…duction. (GH-109440) (#109481)

gh-109414: Add some basic information about venvs in the introduction. (GH-109440)
(cherry picked from commit a6846d4)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Co-authored-by: Victor Stinner <vstinner@python.org>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vsajip @vstinner @csm10495
pythongh-109414: Add some basic information about venvs in the introd…
b7ff008 
…uction. (pythonGH-109440)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsajip @vstinner @miss-islington @brettcannon
0