gh-109276: libregrtest: WASM use filename for JSON #109326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
359d425 to
c45529b
Compare
This was referenced Sep 12, 2023
|
!buildbot wasm32 |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit c45529b 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Emscripten/WASI still use a file descriptor. It makes no sense to me :-( I'm not sure if buildbots got the right commit. |
On Emscripten and WASI platforms, libregrtest now uses a filename for the JSON file. Passing a file descriptor to a child process doesn't work on these platforms.
ee0cac8 to
9c052ba
Compare
|
!buildbot wasm32 |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 9c052ba 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot wasm32 |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 9c052ba 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
wasm32-emscripten node (dynamic linking) PR failed with: wasm32-wasi PR failed with: |
|
I just merged PR #109337 which collect more data in test.support and test.support sub-modules. |
wasm32-emscripten node (dynamic linking) 3.x: test.pythoninfo, support.is_emscripten: True and sys.platform: emscripten as expected. wasm32-emscripten node (pthreads) 3.x: test.pythoninfo, support.is_emscripten: True and sys.platform: emscripten as expected wasm32-wasi 3.x: test.pythoninfo, support.is_wasi: True and sys.platform: wasi as expected |
|
!buildbot wasm32 |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit c436370 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot wasm32 |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 4c8d5c8 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot wasm32 |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 4e2cfab 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Ok, I wrote a clean fix from this debug PR: PR #109340. |
|
wasm32-wasi PR failed: the WASI test worker process doesn't seem to have access to |
I merged this PR instead of this DEBUG PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Emscripten and WASI platforms, libregrtest now uses a filename for the JSON file. Passing a file descriptor to a child process doesn't work on these platforms.