gh-108303: Move tokenize-related data to Lib/test/tokenizedata
#109265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should not |
I think so, yes. |
vstinner
reviewed
Sep 11, 2023
Lib/test/test_tokenize.py
Outdated
| fn = support.findfile("tokenize_tests.txt") | ||
| tempdir = os.path.dirname(fn) or os.curdir | ||
| fn = support.findfile("tokenize_tests.txt", subdir='tokenizedata') | ||
| tempdir = os.path.dirname(os.path.dirname(fn)) or os.curdir |
There was a problem hiding this comment.
I'm not sure about the logical to get tempdir here. Maybe start from file instead? Why is it called tempdir? That's Lib/test/, the directory of test files, no?
There was a problem hiding this comment.
This is not something I am modifing here. I only changed
tempdir = os.path.dirname(fn) or os.curdir
to be
tempdir = os.path.dirname(os.path.dirname(fn)) or os.curdir
I can open a new issue about it and dig into it later :)
vstinner
reviewed
Sep 11, 2023
Co-authored-by: Victor Stinner <vstinner@python.org>
|
@serhiy-storchaka: Do you want to review the updated PR? It LGTM. |
|
@vstinner thanks for your help! 👍 |
serhiy-storchaka
approved these changes
Sep 12, 2023
|
Should it be backported? |
|
Similar PRs were not backported: |
|
|
I don't think so. I prefer to minimize backports, and here it's unlikely that we modify test files in stable versions. |
@sobolevn: Oh, you need to add the new directory to TESTSUBDIRS in Makefile.pre.in. Can you please create a new PR to fix that? |
|
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Sep 13, 2023
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Sep 21, 2023
…ythonGH-109265) (cherry picked from commit 1110c5b)
|
GH-109677 is a backport of this pull request to the 3.12 branch. |
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Sep 21, 2023
…ythonGH-109265) (cherry picked from commit 1110c5b)
|
GH-109678 is a backport of this pull request to the 3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
57AE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, I think, we can move more files to this folder, since there are quite a lot of artefacts for
tokenizeand similar tools.