8000 gh-108740: Fix "make regen-all" race condition by vstinner · Pull Request #108741 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-108740: Fix "make regen-all" race condition #108741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 6, 2023
Merged

gh-108740: Fix "make regen-all" race condition #108741

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3afb66f
gh-108740: Fix "make regen-all" race condition
vstinner Aug 31, 2023
6a909dd
Update Doc/using/configure.rst
vstinner Sep 2, 2023
af96ee6
Style
erlend-aasland Sep 6, 2023
a760e70
Use DEEPFREEZE_C in target rule as well
erlend-aasland Sep 6, 2023
418d72e
Revert "Use DEEPFREEZE_C in target rule as well"
erlend-aasland Sep 6, 2023
66e8d70
Use $(DEEPFREEZE_C)
vstinner Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use $(DEEPFREEZE_C)
  • Loading branch information
@vstinner
vstinner committed Sep 6, 2023
commit 66e8d7013c39111118ad0e3c8a75202d38e8e8a2
2 changes: 1 addition & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,7 @@ regen-deepfreeze: $(DEEPFREEZE_C)
DEEPFREEZE_DEPS=$(srcdir)/Tools/build/deepfreeze.py Include/internal/pycore_global_strings.h $(FREEZE_MODULE_DEPS) $(FROZEN_FILES_OUT)

# BEGIN: deepfreeze modules
Python/deepfreeze/deepfreeze.c: $(DEEPFREEZE_DEPS)
$(DEEPFREEZE_C): $(DEEPFREEZE_DEPS)
$(PYTHON_FOR_FREEZE) $(srcdir)/Tools/build/deepfreeze.py \
Python/frozen_modules/importlib._bootstrap.h:importlib._bootstrap \
Python/frozen_modules/importlib._bootstrap_external.h:importlib._bootstrap_external \
Expand Down
2 changes: 1 addition & 1 deletion Tools/build/freeze_modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ def regen_makefile(modules):
pyfiles = []
frozenfiles = []
rules = ['']
deepfreezerules = ["Python/deepfreeze/deepfreeze.c: $(DEEPFREEZE_DEPS)",
deepfreezerules = ["$(DEEPFREEZE_C): $(DEEPFREEZE_DEPS)",
"\t$(PYTHON_FOR_FREEZE) $(srcdir)/Tools/build/deepfreeze.py \\"]
for src in _iter_sources(modules):
frozen_header = relpath_for_posix_display(src.frozenfile, ROOT_DIR)
Expand Down
0