8000 gh-108455: peg_generator: make the mypy config slightly stricter by AlexWaygood · Pull Request #108627 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-108455: peg_generator: make the mypy config slightly stricter #108627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2023
Merged

gh-108455: peg_generator: make the mypy config slightly stricter #108627

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1764adb
Enable `--no-implicit-reexport`
AlexWaygood Aug 29, 2023
d4a5b56
Enable the `truthy-bool` error code
AlexWaygood Aug 29, 2023
c7372c1
Enable the `ignore-without-code` error code
AlexWaygood Aug 29, 2023
d4912ef
Explicitly note that `--warn-unreachable` cannot yet be enabled
AlexWaygood Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Enable --no-implicit-reexport
  • Loading branch information
@AlexWaygood
AlexWaygood committed Aug 29, 2023
commit 1764adb65cd48ce1831db0f092d96d996a49f95d
1 change: 0 additions & 1 deletion Tools/peg_generator/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ strict = True

# except for a few settings that can't yet be enabled:
warn_return_any = False
no_implicit_reexport = False

[mypy-pegen.grammar_parser]
strict_optional = False
Expand Down
5 changes: 4 additions & 1 deletion Tools/peg_generator/pegen/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
import traceback
from typing import Tuple

from pegen.build import Grammar, Parser, ParserGenerator, Tokenizer
from pegen.grammar import Grammar
from pegen.parser import Parser
from pegen.parser_generator import ParserGenerator
from pegen.tokenizer import Tokenizer
from pegen.validator import validate_grammar


Expand Down
0