8000 gh-108598: clarify limit on length of sequences which can be shuffle()d by d-rideout · Pull Request #108610 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-108598: clarify limit on length of sequences which can be shuffle()d #108610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

d-rideout
Copy link
@d-rideout d-rideout commented Aug 29, 2023

@d-rideout d-rideout requested a review from rhettinger as a code owner August 29, 2023 03:44
@ghost
Copy link
ghost commented Aug 29, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@rhettinger rhettinger self-assigned this Aug 31, 2023
@rhettinger
Copy link
Contributor

Thank you for the suggestion, but after reading the edit and the associated discussion, I think we should decline.

To my eyes, the edit doesn't clarify anything but I do see how it might feel a little more satisfying to a highly technical user like yourself who already thoroughly understand PRNG periods, state spaces, shuffling algorithms etc. For other users, I think the current text has served us well for almost two decades.

@rhettinger rhettinger closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider a faster alternative algorithm for random.shuffle()
3 participants
0