Cleanup test code

python · pitrou · Aug 30, 2023 · Aug 28, 2023 · Aug 30, 2023 · Aug 30, 2023
commit 1b62ab02d61e75a7bbcda20e21ba0d36007fb09a
@@ -5342,16 +5342,6 @@ def test_ignore_listener(self):
         finally:
             conn.close()
 
-# Utility functions used as target for spawn Process
-def put_one_in_queue(queue):
-    queue.put(1)
-
-def put_two_and_nest_once(queue):
-    queue.put(2)
-    process = multiprocessing.Process(target=put_one_in_queue, args=(queue,))
-    process.start()
-    process.join()
-
 class TestStartMethod(unittest.TestCase):
     @classmethod
     def _check_context(cls, conn):
@@ -5453,10 +5443,23 @@ def test_mixed_startmethod(self):
                 p.start()
                 p.join()
 
+    @classmethod
+    def _put_one_in_queue(cls, queue):
+        queue.put(1)
+
+    @classmethod
+    def _put_two_and_nest_once(cls, queue):
+        queue.put(2)
+        process = multiprocessing.Process(target=cls._put_one_in_queue, args=(queue,))
+        process.start()
+        process.join()
+
     def test_nested_startmethod(self):
+        # gh-108520: Regression test to ensure that child process can send its
+        # arguments to another process
         queue = multiprocessing.Queue()
 
-        process = multiprocessing.Process(target=put_two_and_nest_once, args=(queue,))
+        process = multiprocessing.Process(target=self._put_two_and_nest_once, args=(queue,))
         process.start()
         process.join()