8000 gh-107211: No longer export internal functions (7) by vstinner · Pull Request #108425 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-107211: No longer export internal functions (7) #108425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2023
Merged

gh-107211: No longer export internal functions (7) #108425

merged 2 commits into from
Aug 24, 2023

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Aug 24, 2023 •
edited by bedevere-bot
Loading

No longer export these 3 internal C API functions:

  • _PyUnicode_EncodeUTF16()
  • _PyUnicode_EncodeUTF32()
  • _PyUnicode_FromId()

Change comment style to "// comment" and add comment explaining why other functions have to be exported.

@bedevere-bot bedevere-bot mentioned this pull request Aug 24, 2023
Closed
@vstinner vstinner force-pushed the dont_export4 branch 2 times, most recently from 136e07b to d0152f8 Compare August 24, 2023 14:52
@vstinner
pythongh-107211: No longer export internal functions (7)
25d79fc 
No longer export _PyUnicode_FromId() internal C API function.

Change comment style to "// comment" and add comment explaining why
other functions have to be exported.
@vstinner vstinner merged commit f1ae706 into python:main Aug 24, 2023
@vstinner vstinner deleted the dont_export4 branch August 24, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot
0