8000 gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs by erlend-aasland · Pull Request #108281 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs #108281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 28, 2023
Merged

gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs #108281

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4f89b4c
gh-108278: Clean up some sqlite3 connection APIs
erlend-aasland Aug 22, 2023
634217b
Sphinx fixup
erlend-aasland Aug 22, 2023
7fa3edb
Pull in main
erlend-aasland Aug 23, 2023
cedd33a
Restrict PR to only touch the UDF creation APIs
erlend-aasland Aug 23, 2023
54e35d5
Update docs
erlend-aasland Aug 23, 2023
833197a
Add test
erlend-aasland Aug 23, 2023
661cd7a
Update Doc/whatsnew/3.13.rst
erlend-aasland Aug 23, 2023
f72c5e9
Pull in main
erlend-aasland Aug 27, 2023
37205c4
Pull in main
erlend-aasland Aug 28, 2023
15cf809
Address review: inline tests
erlend-aasland Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to 8000
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test
  • Loading branch information
@erlend-aasland
erlend-aasland committed Aug 23, 2023
commit 833197abe60f2cfdf61dad8dfb0216dee922072f
20 changes: 20 additions & 0 deletions Lib/test/test_sqlite3/test_userfunctions.py
View file A9A8
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,26 @@ def test_func_return_illegal_value(self):
self.assertRaisesRegex(sqlite.OperationalError, msg,
self.con.execute, "select badreturn()")

def test_func_keyword_args(self):
regex = (
r"Passing keyword arguments 'name', 'narg' and 'func' to "
r"_sqlite3.Connection.create_function\(\) is deprecated. "
r"Parameters 'name', 'narg' and 'func' will become "
r"positional-only in Python 3.15."
)

def check(*args, **kwds):
with self.assertWarnsRegex(DeprecationWarning, regex) as cm:
self.con.create_function(*args, **kwds)
self.assertEqual(cm.filename, __file__)

def noop():
return None

check("noop", 0, func=noop)
check("noop", narg=0, func=noop)
check(name="noop", narg=0, func=noop)


class WindowSumInt:
def __init__(self):
Expand Down
0