Apply suggestions from code review

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
python · serhiy-storchaka · Apr 24, 2024 · Aug 21, 2023 · Aug 22, 2023 · Aug 24, 2023
commit 299d437f02fc1332f9c9a4f773875a93280c69cc
diff --git a/Doc/library/types.rst b/Doc/library/types.rst
@@ -488,8 +488,9 @@ Additional Utility Classes and Functions
    Unlike :class:`object`, with :class:`!SimpleNamespace` you can add and remove
    attributes.
 
-   :py:class:`SimpleNamespace` objects may be initialized either
-   with keyword arguments or with a single positional argument.
+   :py:class:`SimpleNamespace` objects may be initialized
+   in the same way as :class:`dict`: either with keyword arguments,
+   with a single positional argument, or with both.
    When initialized with keyword arguments,
    those are directly added to the underlying namespace.
    Alternatively, when initialized with a positional argument,

diff --git a/Doc/whatsnew/3.13.rst b/Doc/whatsnew/3.13.rst
@@ -410,7 +410,7 @@ types
 
 * :class:`~types.SimpleNamespace` constructor now allows specifying initial
   values of attributes as a positional argument which must be a mapping or
-  an iterable or key-value pairs.
+  an iterable of key-value pairs.
   (Contributed by Serhiy Storchaka in :gh:`108191`.)
 
 typing

diff --git a/Lib/test/test_types.py b/Lib/test/test_types.py
@@ -1741,6 +1741,12 @@ def test_constructor(self):
         ns4 = types.SimpleNamespace({'x': 1, 'y': 2}, x=4, z=3)
         ns5 = types.SimpleNamespace([['x', 1], ['y', 2]], x=4, z=3)
         ns6 = types.SimpleNamespace(UserDict({'x': 1, 'y': 2}), x=4, z=3)
+        ns7 = types.SimpleNamespace({'x': 1, 'y': 2})
+        ns8 = types.SimpleNamespace([['x', 1], ['y', 2]])
+        ns9 = types.SimpleNamespace([], x=4, z=3)
+        ns10 = types.SimpleNamespace({}, x=4, z=3)
+        ns11 = types.SimpleNamespace([])
+        ns12 = types.SimpleNamespace({})
 
         with self.assertRaises(TypeError):
             types.SimpleNamespace([], [])